Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Means to switch Search Modes via Keyboard #67

Closed
brumm opened this issue Feb 28, 2010 · 24 comments · Fixed by #786
Closed

Means to switch Search Modes via Keyboard #67

brumm opened this issue Feb 28, 2010 · 24 comments · Fixed by #786
Assignees

Comments

@brumm
Copy link

@brumm brumm commented Feb 28, 2010

Suppose I have Quicksilver open and have navigated to my Downloads folder.
Now I want to select all .avi files, so I type "avi", but QS jumps to the first good match – I would like to be able to hit, say, capslock or whatever, to switch between the different search modes.

(Snap to best (default) > filter Results > filter Catalog > repeat)

@knoopx
Copy link

@knoopx knoopx commented Feb 28, 2010

is there any way of doing this right now?

@brumm
Copy link
Author

@brumm brumm commented Feb 28, 2010

not that I know of, hence the feature request.
(unless you are asking if the different searchmodes themselves are there; they are – see here: http://img130.imageshack.us/img130/4803/bildschirmfoto20100228ua.png )

@ghost
Copy link

@ghost ghost commented Mar 1, 2010

I was trying to do nearly this exact same thing earlier, just with .mp4s rather than .avis - to me it seems that QS doesn't look at file extensions, and that's why it won't show all the matching files.
I go into my Downloads folder which has a bunch of mp4s, and when I type 'mp4', in either snap to best or filter results, sorted by either name or score, nothing is selected and I end up in text entry mode. (Filter catalog has a result, but it's completely unrelated because it's searching everything.)
When you search for 'avi' in your Downloads folder, does QS pick up the .avi extensions on files?

@brumm
Copy link
Author

@brumm brumm commented Mar 1, 2010

Yes, it does:
(navigated to /Pictures > switched to "Filter results" > typed "png")
http://img63.imageshack.us/img63/4285/bildschirmfoto20100301u.png

Interestingly, when I tried this in /Movies with "flv", QS would only show one of a total three flv files.

@ghost
Copy link

@ghost ghost commented Mar 1, 2010

I noticed in that screenshot the file extensions were upper case - I renamed made the extensions on my mp4s upper case, and QS picked them up. Same with a bunch of PDFs I had.

After some deep excavation of QSense.m and QSObjectRanker.m, it turns out that the lower case extensions were being recognized, but their score was below the minimum required to show up in the results. This was because QSense didn't pick up the fact that the period before the extension was a word boundary, and it thought file extensions were just a bunch of letters at the end of a word, which have a very low rank. Upper case letters are always given a higher rank, and that's why upper case extensions were able to be searched.

I made the character set QSense uses to determine word boundaries (which was just whitespace) include the period character, and now regardless of their case, I can search for file extensions and the expected results show up.

This fix is in SHA: 6c027ed120039c567a7c23839c5a90fdf25c934a

@brumm
Copy link
Author

@brumm brumm commented Mar 3, 2010

Awesome :) Any news on the original request?

@ghost
Copy link

@ghost ghost commented Mar 3, 2010

That patch makes it so that when you navigate to a folder you can type a file extension, and the results are filtered to show files matching that extension - this might achieve what you without having to manually switch search modes with a key shortcut.
I've uploaded a compiled copy at http://neurolepsy.com/Quicksilver.zip so you can try it and see if the patch above makes QS behave the way you want.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 4, 2010

Looks good,

I still think a way to do what kukuku wanted is a good idea. I'll maybe look at making some kind of trigger, or action for it (which could then be set up as a trigger)

@brumm
Copy link
Author

@brumm brumm commented Mar 4, 2010

Yay!

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 17, 2011

Neurolepsy:

Was this ever merged to ß59? Seems to be working properly, so can this be closed?
6c027ed gives 404 error... (you linked to it 5 comments back)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 18, 2011

Sorry this wasn't released in ß59 guys.

The commit has now been merged to Quicksilver master and will be available in ß60 :)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Apr 18, 2011

Should this be closed? The original feature request (change search mode by shortcut) is still open.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 18, 2011

... I closed this 5 hours ago ;)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Apr 18, 2011

Well...actually I meant it shouldn't be closed, since the original feature request wasn't fixed, just something that developed during the discussion. "Finding files by extension" was fixed, but "switching search mode with keyboard" wasn't. So the original request is still valid and should remain open.

@pjrobertson pjrobertson reopened this Apr 18, 2011
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 18, 2011

Woops, sorry for the confusion. Right you are!

Maybe have something like shift or CMD as a shortcut for doing this, but then that could interfere with people who have QS open with a single key command.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 20, 2011

I wasn't sure what the best shortcut would be.

For the time being, I've made it ⌘→ which toggles through the 3 search cases.

There is now though, no way of knowing this unless you've already been told (adding to the steep learning curve o Quicksilver)
If someone can think of any ideas, then let me know :)

I could also add ⌘← for going 'back' through the list.

We should also have shortcuts for 'sort by name' and 'sort by score' as well, but I don't know what

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 20, 2011

P.S. @kukuku This is a really good idea! I'd never used the different search modes before, but having implemented this and fixed bug #413 this is seriously cool!

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 20, 2011

Thoughts? http://i.imgur.com/i6Yts.png
OK it makes it a bit longer but I think it's fine

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 20, 2011

I've added a way of easily seeing which search mode you're in http://i.imgur.com/FJd6Q.png

I've also stuck in ⌘← to toggle back as I think it makes more sense.

I might add ⌘↓ and ⌘↑ to switch between the 'sort by score' and 'sort by name' things now as well if people think it's worth it.

Edit: Updated image: http://i.imgur.com/5sPuI.png

@ghost
Copy link

@ghost ghost commented Jul 22, 2011

i think that's a great use of the extra space above the results list. have you tried removing the brackets and making the text there something like "Snap to Best, Sort by Name"?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 22, 2011

I guess the brackets are a bit redundant, and don't really add anything to
it. I'll take them out then post another image to see what we all think :)

On 22 July 2011 03:09, neurolepsy <
reply@reply.github.com>wrote:

i think that's a great use of the extra space above the results list. have
you tried removing the brackets and making the text there something like
"Snap to Best, Sort by Name"?

Reply to this email directly or view it on GitHub:
#67 (comment)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 22, 2011

There may not be enough space to add the 'sort by name' part, but I'll have a look

Here's a pic with the brackets removed and with the sort by... part added. I think it's good to have it, but it does now look a bit cluttered. Thoughts?
http://i.imgur.com/2IEtQ.png

@ghost
Copy link

@ghost ghost commented Jul 22, 2011

yeah, the Sort By ... is too much, but the search mode by itself works well.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 22, 2011

Cool. To see the sort by mode, it's only 1 click away so I don't think that's too bad :)

I'll remove it, clean it up then issue a pull request (maybe once we've cleaned some of the other pull requests up first :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants