Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Shelf/Clipboard panels won’t dock to a screen edge #696

Closed
skurfer opened this Issue · 9 comments

3 participants

@skurfer
Owner

I realize not everyone has this problem, but I have for years. I’ve got a quicksilver test account in which I’ve removed the prefs, app support, and caches. I set up Quicksilver, then install the Shelf and Clipboard modules and I can still reproduce the problem. Dragging a panel all the way to the screen edge is no different from dragging any other window.

At one point, we thought it might be related to multiple displays. (I’m on a MacBook Pro, and for what it’s worth, this problem predates my current hardware.) I’ve disconnected all external displays, cleaned out the test account, and rebooted and it makes no difference.

In many respects, these panels act like they are already docked to an edge:

  1. Mousing out of them or switching applications causes them to fade and close.
  2. I can’t get them to stay on screen (intentionally). Switching applications usually makes them fade and close.
  3. They sometimes decide to stay on screen on their own. In this case, clicking close will not get rid of the window, but the next time I mouse out of the panel after clicking close, it will fade and close.
  4. I use the Graphite appearance where the close/minimize/zoom controls are always the same gray, so I only noticed this the other day in the test account which uses the default “Blue”: The close/minimize/zoom controls are almost always disabled. Resizing the panel sometimes causes them to “light up”, at which point I can minimize and close normally. Dragging to a screen edge after the controls are enabled still doesn’t trigger the docking behavior.
  5. The obvious one: I can’t dock them to an edge (which is what you’d expect if it’s already docked).

So the firs thing I wonder (and haven’t ben able to figure out): How does a panel decide whether or not it’s docked to an edge? Where is the state stored?

Maybe we should set up a VNC session to my test account so someone else can see what I’m talking about. :-)

@skurfer
Owner

I’ve found that I can get it to dock (sort of). If I drag it slightly off the edge of the screen and leave it there, it slides off the screen when closing instead of fading in place. In rare cases, I can get it to reappear by mousing to the screen edge but in most cases, it won’t reappear without ⌘L or ⌥⌘S. But when it does reappear, it slides back onto the screen from that edge. I’ve found that resizing the panel after it’s docked causes it to consistently reappear when mousing to that edge. So it’s partially working.

But there’s no animation when you approach the edge to let you know it’s docking (it doesn’t snap to the edge or expand or anything), and once docked, the height stays the same. (It’s supposed to expand to be as tall as the screen, right?)

@charlie981947

I've had a very stable shelf and an unstable clipboard and what I've discovered wrt clipboard is that if I place it on the left or right side of the screen it has problems.

On the left side I have a 2nd display and if the display is off then the clipboard has to be recovered via the ⌘L sequence.

If I dock it on the right side in the middle I can make it bounce but if I move the cursor to the left side very quirkly it does not bounce. See below for my 80% observation.

If I place the clipboard on the bottom it behaves much better. However, when I bring the clipboard onto the screen I have to go up the left side and if I then move the cursor to the right at about the 80% mark the clipboard closes.

For some real fun I made the mistake of clicking adjust rows to fit - I won't do that again.

All in all my clipboard is a disaster so I use jumpcut.

@HenningJ
Owner

Great...testing your problem broke my shelf. Now I have the same problems.
I moved it to the screen edge again and now it slides out of view when it disappears. But when I move the mouse to that screen edge, it doesn't slide back into view again. But when I press ⌥⌘S, it does slide...

Another thing it noticed: Now that my shelf is in that weird state you described, the title bar doesn't seem to be part of the window anymore. Meaning, if you move your mouse from the main part of the window to the title bar, the window will disappear.

On my clipboard (which is in the normal, working state), the title bar is a normal part of the window.

I'll now try to figure out what's the difference between the two windows.

(It’s supposed to expand to be as tall as the screen, right?)

No. It never did that for me. I had both the shelf and the clipboard docked to the right screen edge, both taking about half of the height of the screen.

@HenningJ
Owner

Ok, I couldn't find any differences between the working clipboard window and the broken shelf window.

But I did restart QS and now the shelf is docked like it's supposed to be. Weird.

@skurfer
Owner

But when I move the mouse to that screen edge, it doesn't slide back into view again. But when I press ⌥⌘S, it does slide...

Try resizing it a bit after it becomes visible. On my machine, that makes it start sliding out again (until the next launch).

Among the details I omitted, once I figured out how to dock the panels, it took me a long time to get them to work immediately after a launch (without manually calling them up and resizing them once). I still can’t get them to work on launch if I stick them to the left edge, but if I stick them to the bottom, they’ll work on startup. Haven’t tried the right. I have the Dock on the right because I still believe it’s a NeXT system. :-)

@skurfer
Owner

Another data point: I’ve been running with the Clipboard and Shelf docked (to the bottom edge) for a few days now and I notice they don’t slide up after a relaunch of Quicksilver when the mouse goes to that edge. However, if you drag a file to that edge, they pop up without fail.

FYI, I have also been running a build that includes #692, but I see the same behavior building from master.

@HenningJ
Owner

Another thing I noticed recently: When you have the clipboard and shelf docked to the side and they are both hidden, and then you drag something to the clipboard it slides out just fine. But if you drag something to the shelf, it wont slide out. Unless you drag it to the place where the top and bottom bars/borders will appear.

I'm currently working on combining the shelf and clipboard plugins into an single plugin, unifying them into the same architecture (same .nib, window controllers...). Hopefully, in the process I will root out any differences between them and fix some of the weirdness.

@skurfer
Owner

I'm currently working on combining the shelf and clipboard plugins into an single plugin, unifying them into the same architecture (same .nib, window controllers...). Hopefully, in the process I will root out any differences between them and fix some of the weirdness.

I was going to look at why docked windows won’t slide out after a restart. I suspect that the problem is in QSDockingWindow and not in the plug-ins, so it shouldn’t conflict with what you’re working on, but I wanted to check with you before I started.

@HenningJ
Owner

I think you're right, the problem should be in QSDockingWindow.
Go ahead and look into it.

@skurfer skurfer closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.