Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Scripts broken #814

Closed
rdohms opened this issue Apr 13, 2012 · 5 comments
Closed

Extra Scripts broken #814

rdohms opened this issue Apr 13, 2012 · 5 comments

Comments

@rdohms
Copy link

rdohms commented Apr 13, 2012

After the latest update, the items in extra scripts will not show up anymore. (sleep, restart etc..) ß67 (3924)

@pjrobertson
Copy link
Member

pjrobertson commented Apr 13, 2012

I confirmed this yesterday. Looking into it

On 13 April 2012 09:41, Rafael Dohms <
reply@reply.github.com

wrote:

After the latest update, the items in extra scripts will not show up
anymore. (sleep, restart etc..) 67 (3924)


Reply to this email directly or view it on GitHub:
#814

@pjrobertson
Copy link
Member

pjrobertson commented Apr 13, 2012

@HenningJ - your wildcards commit broke this:

2824190dc831f7c2cb52fd6926313145739a7916 is the first bad commit
commit 2824190dc831f7c2cb52fd6926313145739a7916
Author: Henning Jungkurth <henning.jungkurth@gmail.com>
Date:   Tue Feb 21 22:35:58 2012 +0100

    Changed resolving wildcards in paths. Fixes #633.

:040000 040000 f6cf501c8ae141992edeaee8c1ee5243377470a2 373617a9beb09534a8d96c8609bc7258158e31e1 M Quicksilver

Do you want to look into this seeing as you know what you did? If you're busy @skurfer probably knows more about it than me as he merged the pull request.

I'll take a 5 minute look at it now, if I get nowhere I'll leave it to one of you two if it's OK

@HenningJ
Copy link
Contributor

HenningJ commented Apr 13, 2012

oups...I'll take a look at it

@pjrobertson
Copy link
Member

pjrobertson commented Apr 13, 2012

OK I'll leave it to you

On 13 April 2012 12:59, Henning Jungkurth <
reply@reply.github.com

wrote:

oups...I'll take a look at it


Reply to this email directly or view it on GitHub:
#814 (comment)

HenningJ added a commit to HenningJ/Quicksilver that referenced this issue Apr 13, 2012
pjrobertson added a commit that referenced this issue Apr 15, 2012
Fixes wildcard resolving for non-existing paths (issue #814)
HenningJ added a commit that referenced this issue Apr 15, 2012
@pjrobertson
Copy link
Member

pjrobertson commented Apr 16, 2012

Fixed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants