Fix obsolete plug-in system #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only locally installed and loaded plug-ins would be checked.
Previously, only plug-ins available for download would be checked. We don't care if those are obsolete. We only care about those installed.
Also, ensure that a plug-in is only removed if the one that replaces it is also installed. It *shouldn't* be necessary, but is here as an additional safety check. (In practice, if the new plug-in wasn't installed, the obsoletePlugIns dict should be empty on launch, when this method runs.)
pjrobertson
added a commit
that referenced
this pull request
May 10, 2012
Fix obsolete plug-in system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues we’re seeing in the B68 pre-release.
And some enhancements:
Note that this will get merged to the
releasebranch. The build number will need to be bumped after it’s merged. (I didn’t do it here because this is based onmasterand would cause a merge conflict.)