Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search keyword hits app name in English or local language #952

Closed
hirose31 opened this issue Jun 21, 2012 · 14 comments
Closed

search keyword hits app name in English or local language #952

hirose31 opened this issue Jun 21, 2012 · 14 comments
Milestone

Comments

@hirose31
Copy link

B67 and older: search keywords hits by application name in English. (eg: Calculator.app)
B68: search keywords hits by application name in local language. (eg: 計算機.app "計算機" means calculator in Japanese)

I like previous (B67 and older) behavior. Please rollback search keyword of application name if you will.

@sunteya
Copy link

sunteya commented Jul 24, 2012

+1

it is also a very important feature for me.

@skurfer
Copy link
Member

skurfer commented Jul 24, 2012

I believe this is the same issue being discussed on #730.

@heavenshell
Copy link

+1 to previous (B67 and older) behavior.

@pjrobertson
Copy link
Member

This will be fixed in the next version of Quicksilver. Hold tight :)

On 17 August 2012 19:12, heavenshell notifications@github.com wrote:

+1 to previous (B67 and older) behavior.


Reply to this email directly or view it on GitHubhttps://github.com//issues/952#issuecomment-7830526.

@heavenshell
Copy link

Hi, Thank you for information.

I tried d650232 .

  1. $ git clone https://github.com/skurfer/Quicksilver
  2. $ cd Quicksliver
  3. $ git checkout -b origin/issue730
  4. $ git submodule init
  5. $ git submodule update
  6. Open Quicksilver.xcodeproj
  7. Build Quicksilver Distribution
  8. Run /tmp/QS/build/Debug/Quicksilver.app

I typed Calculator but Calculator.app did not hit.

I'm using Japanese env.

Is there any setting for behave B67 and older version?

@pjrobertson
Copy link
Member

Try to checkout the master branch (it's been merged in) (git checkout master)
and clone https://github.com/quicksilver/Quicksilver instead.

You will also most likely need to clear your caches (to remove the old entries)
http://qsapp.com/wiki/FAQ#Clearing_the_cache

@heavenshell
Copy link

Hi, thank you for reply.

I tried master branch, but it seems not fixed.
I typed Calculator but Calculator.app did not hit.

I cleared all caches, catalogs(under Application Support), Preferences.

Regards,

@skurfer
Copy link
Member

skurfer commented Aug 18, 2012

Actually, #1017 hasn't been merged into master yet, so you still need to get my issue730 branch for now. Doing that and clearing caches should do the trick. Let us know if not.

@heavenshell
Copy link

HI,

I tried issue730 branch again and didn't hit Calculator.app.
Clearing caches, catalogs and preferences.

What can I help you?(Sorry I can't write Objective-C)

Regards,

@skurfer
Copy link
Member

skurfer commented Aug 19, 2012

Well, if you look in Terminal, does the path /Applications/Calculator.app exist? If so, "Calculator.app" should be the name of the thing in Quicksilver and that should be searchable.

You might not be able to write code, but you can clearly build from source, so I'd recommend changing the Build Configuration for Quicksilver to Debug (with ⇧⌘<). Then run it (with ⌘R). Select the Calculator application in the first pane somehow. You should see a Debug menu in Quicksilver's menu. Go into it and choose "Log Object to Console". You should get something like this:

2012-08-19 14:04:04.827 Quicksilver[92193:303] Printing Object Calculator.app
2012-08-19 14:04:04.828 Quicksilver[92193:303] Dictionary
{
    class = QSObject;
    data =     {
        NSFilenamesPboardType = "/Applications/Calculator.app";
    };
    properties =     {
        QSObjectDetails = "/Applications/Calculator.app";
        QSObjectLabel = Calculator;
        QSObjectName = "Calculator.app";
        QSObjectObjectID = "/Applications/Calculator.app";
        QSObjectType = NSFilenamesPboardType;
    };
}

I want to see what you have for QSObjectName and QSObjectLabel. Those are the things you should be able to search on.

You might need to click Quicksilver's Dock icon to make the menu appear. If, like me, you don't have the Dock icon visible, you'll need to enable it temporarily.

@heavenshell
Copy link

Hi, thank you for comment!

Well, if you look in Terminal, does the path /Applications/Calculator.app exist?

Yes.

$ echo $LANG
ja_JP.UTF-8
$ ls /Applications | grep -i calc
Calculator.app

Here is log outputs.

2012-08-20 21:41:38.238 Quicksilver[60160:303] Printing Object
計算機.app
2012-08-20 21:41:38.238 Quicksilver[60160:303] Dictionary
{
    class = QSObject;
    data =     {
        NSFilenamesPboardType = "/Applications/Calculator.app";
    };
    properties =     {
        QSObjectChildrenLoadDate = "367159268.820568";
        QSObjectDetails = "/Applications/Calculator.app";
        QSObjectName = "\U8a08\U7b97\U6a5f.app";
        QSObjectObjectID = "/Applications/Calculator.app";
        QSObjectType = NSFilenamesPboardType;
    };
}

計算機.app means calculator in Japanese and \U8a08\U7b97\U6a5f means 計算機 in unicode.

I convered unicode string to utf-8 string by Python for checking what unicode string means.

>>> str = u'\u8a08\u7b97\u6a5f'
>>> print str.encode('utf-8')
計算機

QOSObjectLabel didn't show in log. I build ß69:origin/issue730:Debug (3932)
Is my builded branch wrong?

Regards,

@skurfer
Copy link
Member

skurfer commented Aug 20, 2012

I'm moving this discussion over to the comments on #1017, so please look there for my reply.

@heavenshell
Copy link

OK, I commented to #1017.
I check issue730 branch and it works!

@n8henrie
Copy link
Member

Go into it and choose "Log Object to Console".

Oh man, this is handy. Had to enable it in Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants