Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the "Quicksilver Catalog Entries" catalog entry by default. #1041

Merged
merged 1 commit into from Aug 13, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 9, 2012

Fixes #1039

Tiniest change. Doesn't really warrant its own issue :)

skurfer added a commit that referenced this pull request Aug 13, 2012
Disable the "Quicksilver Catalog Entries" catalog entry by default.
@skurfer skurfer merged commit bb5fe40 into quicksilver:master Aug 13, 2012
@skurfer
Copy link
Member

skurfer commented Aug 13, 2012

Merged.

@pjrobertson
Copy link
Member Author

pjrobertson commented Aug 26, 2012

You're right. Users who have enabled it manually will continue to have it
enabled. If you've never messed with the setting, then they will silently
disappear from your catalog, which - as you say - probably isn't the best
thing.

Hopefully users who know about (Catalog) entries will be able to overcome
this hiccup and just go back into the prefs to enable it.

On 26 August 2012 01:13, David Rees notifications@github.com wrote:

Am I right that all the (Catalog) entries will essential disappear for
users until they go back and explicitly enable them? I must admit it took
me a while to figure out what happened. I would expect the default to only
apply on initial install...


Reply to this email directly or view it on GitHubhttps://github.com//pull/1041#issuecomment-8028809.

@studgeek
Copy link

studgeek commented Aug 27, 2012

Ok, in that case I would suggest removing the "for new users" in the release notes:
The "Quicksilver Catalog Entries" preset is now disabled by default for new users (#1041)

@pjrobertson
Copy link
Member Author

pjrobertson commented Aug 27, 2012

Ok, in that case I would suggest removing the "for new users" in the
release notes:

That's probably a good idea. @skurfer, can you alter the release notes?
Thanks for your help David, hopefully it hasn't been too much of a pain

On 27 August 2012 14:27, David Rees notifications@github.com wrote:

Ok, in that case I would suggest removing the "for new users" in the
release notes:
The "Quicksilver Catalog Entries" preset is now disabled by default for
new users (#1041 #1041)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1041#issuecomment-8055692.

@skurfer
Copy link
Member

skurfer commented Aug 27, 2012

That's probably a good idea. @skurfer, can you alter the release notes?

Yeah, I was planning on it.

@studgeek
Copy link

studgeek commented Aug 27, 2012

No worries on my side. Happily I found the email in the developer forum.
If I had realized the release notes were available off the help menu I
would have resolved it even quicker. That's what I get for doing early
releases :).

d

On 8/27/12 1:31 PM, Patrick Robertson wrote:

Ok, in that case I would suggest removing the "for new users" in the
release notes:

That's probably a good idea. @skurfer, can you alter the release notes?
Thanks for your help David, hopefully it hasn't been too much of a pain

On 27 August 2012 14:27, David Rees notifications@github.com wrote:

Ok, in that case I would suggest removing the "for new users" in the
release notes:
The "Quicksilver Catalog Entries" preset is now disabled by
default for
new users (#1041
#1041)


Reply to this email directly or view it on
GitHubhttps://github.com//pull/1041#issuecomment-8055692.


Reply to this email directly or view it on GitHub
#1041 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Quicksilver Catalog Entries' catalog entry should be disabled by default
3 participants