add a dedicated type for Web Search URLs - close #625 #1082

Merged
merged 1 commit into from Sep 21, 2012

Projects

None yet

3 participants

Owner
skurfer commented Aug 29, 2012

As previously discussed, this adds a specific type for search URLs.

The old versions of the web search plug-in will continue to work because the type they depend on, QSURLType, is still set for search URLs. A new version of the web search plug-in that takes advantage of this is in the works.

Owner

I think I should 'go on holiday' more often, you're going coding mad! ;-)

We'll need to be sure we look at all the places/plugins that should be
changed to use QSSearchURLTypes.
I have a feeling that there are other plugins somewhere that use *** as
well

On 29 August 2012 21:11, Rob McBroom notifications@github.com wrote:

As previously discussed, this adds a specific type for search URLs.

The old versions of the web search plug-in will continue to work because
the type they depend on, QSURLType, is still set for search URLs. A _new_version of the web search plug-in that takes advantage of this is in the

works.

You can merge this Pull Request by running:

git pull https://github.com/skurfer/Quicksilver webSearchType

Or view, comment on, or merge it at:

#1082
Commit Summary

  • add a dedicated type for Web Search URLs - close #625#625

File Changes

  • M Quicksilver/Code-QuickStepCore/QSObject_URLHandling.m (7)
  • M Quicksilver/Code-QuickStepCore/QSTypes.h (1)
  • M Quicksilver/Code-QuickStepCore/QSTypes.m (1)
  • _M_Quicksilver/PlugIns-Main/QSCorePlugIn/Code/QSActionProvider_EmbeddedProviders.m
    (4)
  • M Quicksilver/PlugIns-Main/QSCorePlugIn/QSCorePlugIn-Info.plist (2)

Patch Links

Owner
skurfer commented Aug 30, 2012

I have a feeling that there are other plugins somewhere that use *** as well

I think web search is the only one that needs updating. Like I said in the pull request, old stuff should continue to work. Updating would only be for efficiency. (I assume that's what you meant.)

Looked through the old repo that contains all of them. Safari and OmniWeb both used @"***", but only to later call URLObjectWithURL:, which will assign the new type automatically, so they should be good.

Owner
skurfer commented Aug 30, 2012

I think I should 'go on holiday' more often, you're going coding mad! ;-)

Oh, and this. I don't know what happened. I was so unmotivated to do anything Monday (for work, Quicksilver, or personal projects). Tuesday I just started looking for small things to get out of the way, and then went crazy from there. I do think your quietness is a factor. You usually contribute so much that I spend half the day looking it over (which is good). :-) Now I guess it's my turn (which is also good).

Owner

You usually contribute so much that I spend half the day looking it over

The tables have turned, hehe!

Agreed on all your other points. This isn't top priority atm (with my
limited) time so I may leave it for a bit now...

On 30 August 2012 04:18, Rob McBroom notifications@github.com wrote:

I think I should 'go on holiday' more often, you're going coding mad! ;-)

Oh, and this. I don't know what happened. I was so unmotivated to do
anything Monday (for work, Quicksilver, or personal projects). Tuesday I
just started looking for small things to get out of the way, and then went
crazy from there. I do think your quietness is a factor. You usually
contribute so much that I spend half the day looking it over (which is
good). :-) Now I guess it's my turn (which is also good).


Reply to this email directly or view it on GitHubhttps://github.com/quicksilver/Quicksilver/pull/1082#issuecomment-8148222.

You probably know this and I don't know if it matters for this chunk, but FYI Chrome and Firefox search URLs use %s instead of **. I think maybe their plugins convert that to ** so maybe its a non-issue at the level you are working at.

Owner
skurfer commented Aug 30, 2012

Yes, the plug-ins for each browser should be finding the defined searches and replacing %s with ***, and I think the web search plug-in itself does that too, though I don't know if it ever needs to. Probably best to let the plug-ins handle that, as they can do browser specific things. For instance, OmniWeb uses %@ for the placeholder.

@skurfer skurfer referenced this pull request in quicksilver/elements.websearch-qsplugin Sep 20, 2012
Merged

enhancements and cleanup #2

@pjrobertson pjrobertson merged commit 33734e2 into quicksilver:master Sep 21, 2012
@skurfer skurfer referenced this pull request in quicksilver/GoogleChrome-qsplugin Oct 9, 2012
Closed

New web search type #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment