Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow you to copy to.../move to… into all packages/bundles. Fixes #1068 #1091

Merged
merged 1 commit into from Sep 4, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 1, 2012

With the new indirectTypes options, I'd originally made it so you could only copy to folders

Properly set against the release branch

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 4, 2012

I can't search for an application in the third pane, but if I go to /Applications and drill in from there, ⌥/ gets me into one. Is that how it's supposed to work? If so, this looks good.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 4, 2012

With this change, if you → into a folder that contains applications, the applications will show up (along with any other bundles) so that you can directly copy to.../move to... "on top" of the application/bundle or can ⌥→ into the bundle.

What you say sounds about right :)

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 4, 2012

OK, that's what I was seeing. I just didn't know if you were supposed to be able to search for applications directly or get into them without ⌥, but it doesn't sound like it.

skurfer added a commit that referenced this issue Sep 4, 2012
Allow you to copy to.../move to… into all packages/bundles. Fixes #1068
@skurfer skurfer merged commit d06e83b into quicksilver:release Sep 4, 2012
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 4, 2012

As we've said before, to be able to search for Apps directly we'd need to
do something in the 'indirectObjectsForAction…' method. I've just touched
the plist so you can actually see the files when browsing :)

On 4 September 2012 16:33, Rob McBroom notifications@github.com wrote:

OK, that's what I was seeing. I just didn't know if you were supposed to
be able to search for applications directly or get into them without ⌥, but
it doesn't sound like it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1091#issuecomment-8267392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants