Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Recent Objects and Recent Commands in real time #1111

Merged
merged 2 commits into from Sep 16, 2012
Merged

Update Recent Objects and Recent Commands in real time #1111

merged 2 commits into from Sep 16, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Sep 14, 2012

There could be a very long delay between the time you use an object and the time it shows up under "Recent Objects". This makes objects available via the catalog entry as soon as they go into Quickilver’s internal history.

I did this for Recent Commands too, but note that this won’t provide much benefit until the commands can be archived correctly.

The QSCatalogEntryInvalidated notification was already defined, but it wasn’t being used. I’m sure there are other places where having this available will prove useful.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 16, 2012

Looks good and works as advertised. Merged

Not heard about QSCatalogEntryInvalidated before, but it sounds useful. When I was checking how many times writeCatalog: got called a few days ago, I noticed the QSCatalogSourceInvalidated notif was being sent quite often. Perhaps it should be switched out for the …EntryInvalidated notif in some places?

pjrobertson added a commit that referenced this issue Sep 16, 2012
Update Recent Objects and Recent Commands in real time
@pjrobertson pjrobertson merged commit 25e97dd into quicksilver:master Sep 16, 2012
@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 17, 2012

Not heard about QSCatalogEntryInvalidated before, but it sounds useful.

Me either. I went to define something like it and saw that it was already there.

When I was checking how many times writeCatalog: got called a few days ago, I noticed the QSCatalogSourceInvalidated notif was being sent quite often. Perhaps it should be switched out for the …EntryInvalidated notif in some places?

Oh, I'm sure. I tried using QSCatalogSourceInvalidated at first, but when I looked into it further, I saw that it triggers an update for every single entry from that object source. I can't imagine why this would ever be appropriate for the filesystem object source (or any of them really), but I think it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants