Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation/Transifex #1125

Merged
merged 2 commits into from Sep 19, 2012
Merged

Localisation/Transifex #1125

merged 2 commits into from Sep 19, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 19, 2012

This paves the way for using Transifex with the repo.

Things that I've done:

  • Changed the name formate of some of our resources from the old (e.g. English.lproj) the new (en.lproj) names
  • done tx init and added a few test files.

Hopefully this can be merged into master, then I will:

  • Add all the resource files to the tx project
  • Push all the resource files (including my changes from this morning, now that @skurfer has merged them) to Transifex
  • Advertise to everyone to get translating!

Then, when we're ready to go we just do a tx pull and we have all our languages :D

pjrobertson added 2 commits Sep 19, 2012
* Use folders called 'en.lproj' as opposed to the old long name 'English.lproj' format
* Also, add the Sparkle and VDKQueue directories to the .gitignore
@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Sep 19, 2012

There used to be a bug in Xcode that you needed a file called
English.lproj, otherwise you wouldn't be able to edit you
localisations anymore...or something:
"By the way, I find another bug in XCode:
After the English.lproj folder is deleted in XCode, it will fail to
add more localization. "
http://lists.apple.com/archives/xcode-users/2010/Sep/msg00168.html

Is that fixed in Xcode 4?

On Wed, Sep 19, 2012 at 6:13 PM, Patrick Robertson
notifications@github.com wrote:

This paves the way for using Transifex with the repo.

Things that I've done:

Changed the name formate of some of our resources from the old (e.g.
English.lproj) the new (en.lproj) names
done tx init and added a few test files.

Hopefully this can be merged into master, then I will:

Add all the resource files to the tx project
Push all the resource files (including my changes from this morning, now
that @skurfer has merged them) to Transifex
Advertise to everyone to get translating!

Then, when we're ready to go we just do a tx pull and we have all our
languages :D


You can merge this Pull Request by running:

git pull https://github.com/pjrobertson/Quicksilver tx

Or view, comment on, or merge it at:

#1125

Commit Summary

Localisation folder structure changes
Add transifex project file to git

File Changes

M .gitignore (2)
A .tx/config (24)
A Quicksilver/Localized/de.lproj/About.strings (0)
A Quicksilver/Localized/de.lproj/Catalog.strings (0)
A Quicksilver/Localized/de.lproj/Localizable.strings (0)
A Quicksilver/Localized/de.lproj/Preferences.strings (0)
A Quicksilver/Localized/en.lproj/About.strings (0)
A Quicksilver/Localized/en.lproj/Catalog.strings (0)
A Quicksilver/Localized/en.lproj/Localizable.strings (0)
A Quicksilver/Localized/en.lproj/Preferences.strings (0)
A Quicksilver/Localized/en.lproj/QSActionsPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSAppearancePrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSApplicationPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSCatalog.strings (0)
A Quicksilver/Localized/en.lproj/QSHelpersPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSMainMenuPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSPlugInsPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSSearchPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSTriggersPrefPane.strings (0)
A Quicksilver/Localized/es.lproj/About.strings (0)
A Quicksilver/Localized/es.lproj/Catalog.strings (0)
A Quicksilver/Localized/es.lproj/Localizable.strings (0)
A Quicksilver/Localized/es.lproj/Preferences.strings (0)
A Quicksilver/Localized/it.lproj/About.strings (0)
A Quicksilver/Localized/it.lproj/Catalog.strings (0)
A Quicksilver/Localized/it.lproj/Localizable.strings (0)
A Quicksilver/Localized/it.lproj/Preferences.strings (0)
A Quicksilver/Localized/nl.lproj/About.strings (0)
A Quicksilver/Localized/nl.lproj/Catalog.strings (0)
A Quicksilver/Localized/nl.lproj/Localizable.strings (0)
A Quicksilver/Localized/nl.lproj/Preferences.strings (0)
M Quicksilver/Quicksilver.xcodeproj/project.pbxproj (58)

Patch Links

https://github.com/quicksilver/Quicksilver/pull/1125.patch
https://github.com/quicksilver/Quicksilver/pull/1125.diff


Reply to this email directly or view it on GitHub.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 19, 2012

Looks like it is. I've just tested adding more languages for a .strings
file and it all works.

Anyway, quite a few of our .strings files have been in en.lproj folders for
a while. I only changed the remaining few.

If there are no problems then a quick merge would be appreciated.
Translators are queuing up, and I don't want to let them start translating
'til all the content is up!

On 19 September 2012 17:44, Henning Jungkurth notifications@github.comwrote:

There used to be a bug in Xcode that you needed a file called
English.lproj, otherwise you wouldn't be able to edit you
localisations anymore...or something:
"By the way, I find another bug in XCode:
After the English.lproj folder is deleted in XCode, it will fail to
add more localization. "
http://lists.apple.com/archives/xcode-users/2010/Sep/msg00168.html

Is that fixed in Xcode 4?

On Wed, Sep 19, 2012 at 6:13 PM, Patrick Robertson
notifications@github.com wrote:

This paves the way for using Transifex with the repo.

Things that I've done:

Changed the name formate of some of our resources from the old (e.g.
English.lproj) the new (en.lproj) names
done tx init and added a few test files.

Hopefully this can be merged into master, then I will:

Add all the resource files to the tx project
Push all the resource files (including my changes from this morning, now
that @skurfer has merged them) to Transifex
Advertise to everyone to get translating!

Then, when we're ready to go we just do a tx pull and we have all our
languages :D


You can merge this Pull Request by running:

git pull https://github.com/pjrobertson/Quicksilver tx

Or view, comment on, or merge it at:

#1125

Commit Summary

Localisation folder structure changes
Add transifex project file to git

File Changes

M .gitignore (2)
A .tx/config (24)
A Quicksilver/Localized/de.lproj/About.strings (0)
A Quicksilver/Localized/de.lproj/Catalog.strings (0)
A Quicksilver/Localized/de.lproj/Localizable.strings (0)
A Quicksilver/Localized/de.lproj/Preferences.strings (0)
A Quicksilver/Localized/en.lproj/About.strings (0)
A Quicksilver/Localized/en.lproj/Catalog.strings (0)
A Quicksilver/Localized/en.lproj/Localizable.strings (0)
A Quicksilver/Localized/en.lproj/Preferences.strings (0)
A Quicksilver/Localized/en.lproj/QSActionsPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSAppearancePrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSApplicationPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSCatalog.strings (0)
A Quicksilver/Localized/en.lproj/QSHelpersPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSMainMenuPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSPlugInsPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSSearchPrefPane.strings (0)
A Quicksilver/Localized/en.lproj/QSTriggersPrefPane.strings (0)
A Quicksilver/Localized/es.lproj/About.strings (0)
A Quicksilver/Localized/es.lproj/Catalog.strings (0)
A Quicksilver/Localized/es.lproj/Localizable.strings (0)
A Quicksilver/Localized/es.lproj/Preferences.strings (0)
A Quicksilver/Localized/it.lproj/About.strings (0)
A Quicksilver/Localized/it.lproj/Catalog.strings (0)
A Quicksilver/Localized/it.lproj/Localizable.strings (0)
A Quicksilver/Localized/it.lproj/Preferences.strings (0)
A Quicksilver/Localized/nl.lproj/About.strings (0)
A Quicksilver/Localized/nl.lproj/Catalog.strings (0)
A Quicksilver/Localized/nl.lproj/Localizable.strings (0)
A Quicksilver/Localized/nl.lproj/Preferences.strings (0)
M Quicksilver/Quicksilver.xcodeproj/project.pbxproj (58)

Patch Links

https://github.com/quicksilver/Quicksilver/pull/1125.patch
https://github.com/quicksilver/Quicksilver/pull/1125.diff


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1125#issuecomment-8697470.

tiennou added a commit that referenced this issue Sep 19, 2012
@tiennou tiennou merged commit 3b18abd into quicksilver:master Sep 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants