Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Helper for passing input data to an NSTask. #1127

Merged
merged 1 commit into from Sep 22, 2012

Conversation

Projects
None yet
3 participants
Owner

tiennou commented Sep 19, 2012

As it says on the tin ;-)

Owner

tiennou commented Sep 19, 2012

That's required for quicksilver/Calculator-qsplugin#4 to work.

I don't know if it's worth another commit to fix it, but why is the indentation different from line to line?

pjrobertson added a commit that referenced this pull request Sep 22, 2012

Merge pull request #1127 from tiennou/nstask-addition
Helper for passing input data to an NSTask.

@pjrobertson pjrobertson merged commit 75cb686 into quicksilver:master Sep 22, 2012

Owner

pjrobertson commented Sep 22, 2012

Bugger I didn't mean to merge this. My merging finger is too keen!

Two things

  1. What Rob says!
  2. Can you use DRY which the method above this new one? ;-)
Owner

pjrobertson commented Sep 22, 2012

Apologies, point 2 isn't related to DRY, but related to the typical Apple convention of always calling the most complete method with certain parameters as nil.

I've pushed a commit straight to master with the changes. Please shout at me/kick me/tell me off if you're unhappy

Owner

tiennou commented Sep 22, 2012

What are you guys using for indentation ? I have a preference for spaces (that's my Xcode & TextMate default), but some files have been using tabs, and I didn't check before creating the pull...

No issue with the DRY, I hadn't thought about it ;-).

Owner

pjrobertson commented Sep 22, 2012

What I do is use Xcode to do the indentation for me.
Highlight the lines you want to indent, then press ⌃I (that's an eye not an
el)

Here's my Xcode intent settings: http://d.pr/i/m2FT

The only thing that annoys me about this is that comments are not indented
by default. If anybody knows a solution, I'd appreciate it :)

Glad the DRY was OK :)

On 22 September 2012 16:14, Etienne Samson notifications@github.com wrote:

What are you guys using for indentation ? I have a preference for spaces
(that's my Xcode & TextMate default), but some files have been using tabs,
and I didn't check before creating the pull...

No issue with the DRY, I hadn't thought about it ;-).


Reply to this email directly or view it on GitHubhttps://github.com/quicksilver/Quicksilver/pull/1127#issuecomment-8789705.

Owner

skurfer commented Sep 23, 2012

I hate tabs, so I use spaces in TextMate. But since the vast majority of Quicksilver and the plug-in code was done with tabs, I gave up and started using them in Xcode to make it easier on “you tab users”. Apparently, that was silly.

Sounds like we all prefer spaces. Anyone know a way to reindent the whole project without screwing up Git’s history forever? Bah, all the blames point back to that one “Code cleanup” commit now anyway. ;-)

Rob McBroom
via iPhone

Owner

tiennou commented Sep 23, 2012

Yeah, tabs are generally frowed upon by developers since it still depends on the "number of spaces" setting.

There's a thing called uncrustify that does that, but it needs to be configured separately. I have a config file for it somewhere, but IIRC last time I used that (was v0.54, now it's 0.59) but it had a few issues with some Obj-C constructs so I should 1) recall what was the problem 2) try it again ;-).

And yes, you'd leave a pretty hard mark on the history by doing that :-(.

Edit: You can try it out by installing Homebrew then doing a brew install uncrustify.

Owner

pjrobertson commented Sep 23, 2012

I myself aren't too bothered about crossing my t's, dotting my i's or using
space or tabs ;-)

But I do think that ruining our lovely git history wouldn't be a good idea.
OK, it's ruined before the 'Code cleanup' commit as you say, but since then
we've been pretty good :)

On 23 September 2012 17:09, Etienne Samson notifications@github.com wrote:

Yeah, tabs are generally frowed upon by developers since it still depends
on the "number of spaces" setting.

There's a thing called uncrustify that does that, but it needs to be
configured separately. I have a config file for it somewhere, but IIRC last
time I used that (was v0.54, now it's 0.59) but it had a few issues with
some Obj-C constructs so I should 1) recall what was the problem 2) try it
again ;-).

And yes, you'd leave a pretty hard mark on the history by doing that :-(.


Reply to this email directly or view it on GitHubhttps://github.com/quicksilver/Quicksilver/pull/1127#issuecomment-8799836.

Owner

skurfer commented Sep 24, 2012

OK, but it sounds like I can at least switch Xcode over to spaces without pissing anyone off. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment