Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Support presets #1128

Merged
merged 13 commits into from Sep 25, 2012
Merged

Core Support presets #1128

merged 13 commits into from Sep 25, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Sep 20, 2012

This adds, removes, or fixes various catalog presets from the Core Support plug-in. Should fix #654 and #891.

  • Reinstate the Favorite Servers source
  • Fix the Recent Servers source
  • Choose a working icon for Printers
  • Remove references to Sherlock. Great TV show, but no longer an application bundled with OS X. :-)
  • Remove all the proxy objects listed on #654. The objects they provided are all still accessible in other ways.

skurfer added 6 commits Sep 19, 2012
close #654

* Objects provided under the various Application proxies are already
available under Running Applications & Processes
* Volumes proxies were replaced with one normal catalog entry
@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 20, 2012

Not sure why this can't be merged. I've done it three times now locally without issue.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 21, 2012

No merge conflicts here. I'll test this out today

@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 21, 2012

OK, I've fixed the drive icon with the most amazing commit ever, but not sure what to do on Printers.

Since it's already missing for everyone, maybe it can just be a Mountain Lion perk? ;-)

@tiennou
Copy link
Member

@tiennou tiennou commented Sep 21, 2012

Since it's already missing for everyone, maybe it can just be a Mountain Lion perk? ;-)

Are you sure ? I actually had real icons there when I checked what was wrong with #1085 / #1087 (I mean the icons were representing the actual printer).

@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 21, 2012

The icons for the actual printers are fine. We're talking about the icon for the catalog preset.

skurfer added 5 commits Sep 21, 2012
In `ResourceLocations.plist` or a plug-in's `QSResourceAdditions `, you
can now specify different icons for different versions of OS X.

For example, if a resource with the key "Printer" exists on 10.6 and
10.7, but not 10.8, you could define two resources named
"Printer[10.8]" and "Printer". The first will only be used on 10.8
systems. All other OS versions will fall back to the latter resource.

It is also necessary (and possible) in rare circumstances to be more
specific, like "RemoteHost[10.7.3]".
@pjrobertson pjrobertson merged commit 5b3ff1b into quicksilver:master Sep 25, 2012
@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 5, 2012

Well, I'm sorry to report that we are idiots. :-)

I was going to document the new ability to add OS-specific resources. I knew there were other undocumented ways to define resources, so I was looking at all the examples. The value for a resource can be a dictionary (to refer to an icon within a bundle), a string (absolute path), or… wait for it… an array of strings/dictionaries! So you can just stick all the possible icons in an array and the first one found will be used. Much easier than managing things by OS version, and it was there all along.

So I don't think I'm even going to document the new way, as the existing way is easier for devs to manage. The question is: Should we remove the code?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 5, 2012

So I don't think I'm even going to document the new way, as the existing
way is easier for devs to manage. The question is: Should we remove the
code?

Remove our 'new' code? I think so… best to keep things tidy!
Maybe just revert the commits would be easy.

P.S. don't forget #1098 if you're working on the dev ref :)

On 5 October 2012 13:56, Rob McBroom notifications@github.com wrote:

Well, I'm sorry to report that we are idiots. :-)

I was going to document the new ability to add OS-specific resources. I
knew there were other undocumented ways to define resources, so I was
looking at all the examples. The value for a resource can be a dictionary
(to refer to an icon within a bundle), a string (absolute path), or… wait
for it… an array of strings/dictionaries! So you can just stick all the
possible icons in an array and the first one found will be used. Much
easier than managing things by OS version, and it was there all along.

So I don't think I'm even going to document the new way, as the existing
way is easier for devs to manage. The question is: Should we remove the
code?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1128#issuecomment-9174426.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 5, 2012

Remove our 'new' code? I think so… best to keep things tidy!
Maybe just revert the commits would be easy.

Yes, remove the new code. Hopefully I kept the commits nice and focused so they can be reverted cleanly. :-)

@skurfer skurfer mentioned this pull request Oct 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants