Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Icons #1129

Merged
merged 8 commits into from Sep 21, 2012
Merged

New Icons #1129

merged 8 commits into from Sep 21, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 20, 2012

This pull request includes all the icons by Dan Deming-Henes

It also contains a few fixes for the count images (Something I broke during the 64 bit changes) and a single localisation :)

pjrobertson added 6 commits Sep 7, 2012
In the 3rd pane in Primer, for some reason when typing in text mode the 3rd pane's text/view slowly changes to look worse and worse.

Morale of the story? Don't call private methods....? :/
http://strandeddesign.com

The old reference to the mail count badges has been removed, and QS's own badges are now used
Hopefully genstrings will pull the string into the en Localizable.strings file ;-)
@skurfer
Copy link
Member

@skurfer skurfer commented Sep 21, 2012

The badge number centers nicely in Bezel, but it's way down low in Nostromo. Something I need to fix there? Other than that, looks good.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 21, 2012

Let me take a look at the code

On 21 September 2012 15:05, Rob McBroom notifications@github.com wrote:

The badge number centers nicely in Bezel, but it's way down low in
Nostromo. Something I need to fix there? Other than that, looks good.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1129#issuecomment-8765624.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 21, 2012

Lucky for you, it was a bug in the code. Good spot :)

Should be fixed now

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 21, 2012

Oh, it was supposed to go on the icon, not in the upper right of the interface? Makes sense. :-)

Also, I noticed there is a way to "explode" things selected with ⌘A: → or /. But we should make something that works with the comma-trick, too.

skurfer added a commit that referenced this issue Sep 21, 2012
@skurfer skurfer merged commit b7885ef into quicksilver:master Sep 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants