make windows visible above full-screen apps

[skurfer]

fixes #740

A little more DRY than the previous attempt.

[pjrobertson]

Works as advertised on 10.7

I see the prefs window pops up in full screen apps :)

Is it worth us checking this on 10.6? (ping @HenningJ )

[skurfer]

Is it worth us checking this on 10.6?

I think so, just to make sure the | 256 doesn't have any side-effects.

[HenningJ]

How do I check that? I don't really have full screen apps on 10.6 ;)

[skurfer]

I think mainly just check that the interface still appears on all spaces (and not just on the space where it was launched).

[pjrobertson]

Didn't iPhoto and a few other apps have unofficial full screen things in SL?
Maybe you could check it with the iTunes visualiser in full screen as well?

On 25 September 2012 18:20, Rob McBroom notifications@github.com wrote:

I think mainly just check that the interface still appears on all spaces
(and not just on the space where it was launched).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1138#issuecomment-8862523.

[HenningJ]

ok...I check this. Apart from what we discussed on IRC (about MAC_OS_X_VERSION_10_7) it works as before: works fine on all space. But not in iTunes full screen visualizer. But I checked: that didn't work in previous versions either.

[skurfer]

OK, this should build on 10.6 now.

[HenningJ]

Didn't we decide to redefine MAC_OS_X_VERSION_10_7 and friends?

[skurfer]

I saw that there was precedent for using literals like 1060 elsewhere and I didn't really like the idea of redefining things from AvailabilityMacros.h locally. But if we're going to do it, why not go all the way and just include the 10.8 version of that file in the project? :-) Less room for mistakes and omissions.