Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make windows visible above full-screen apps #1138

Merged
merged 2 commits into from Oct 4, 2012
Merged

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Sep 24, 2012

fixes #740

A little more DRY than the previous attempt.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 25, 2012

Works as advertised on 10.7

I see the prefs window pops up in full screen apps :)

Is it worth us checking this on 10.6? (ping @HenningJ )

@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 25, 2012

Is it worth us checking this on 10.6?

I think so, just to make sure the | 256 doesn't have any side-effects.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Sep 25, 2012

How do I check that? I don't really have full screen apps on 10.6 ;)

@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 25, 2012

I think mainly just check that the interface still appears on all spaces (and not just on the space where it was launched).

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 25, 2012

Didn't iPhoto and a few other apps have unofficial full screen things in SL?
Maybe you could check it with the iTunes visualiser in full screen as well?

On 25 September 2012 18:20, Rob McBroom notifications@github.com wrote:

I think mainly just check that the interface still appears on all spaces
(and not just on the space where it was launched).


Reply to this email directly or view it on GitHubhttps://github.com//pull/1138#issuecomment-8862523.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Sep 25, 2012

ok...I check this. Apart from what we discussed on IRC (about MAC_OS_X_VERSION_10_7) it works as before: works fine on all space. But not in iTunes full screen visualizer. But I checked: that didn't work in previous versions either.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 2, 2012

OK, this should build on 10.6 now.

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Oct 2, 2012

Didn't we decide to redefine MAC_OS_X_VERSION_10_7 and friends?

@skurfer
Copy link
Member Author

@skurfer skurfer commented Oct 2, 2012

I saw that there was precedent for using literals like 1060 elsewhere and I didn't really like the idea of redefining things from AvailabilityMacros.h locally. But if we're going to do it, why not go all the way and just include the 10.8 version of that file in the project? :-) Less room for mistakes and omissions.

pjrobertson added a commit that referenced this issue Oct 4, 2012
make windows visible above full-screen apps
@pjrobertson pjrobertson merged commit d41c81e into master Oct 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants