Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to QSURLExtractor #1150

Merged
merged 4 commits into from Oct 4, 2012
Merged

improvements to QSURLExtractor #1150

merged 4 commits into from Oct 4, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Oct 2, 2012

Well, there you go. @pjrobertson tricked me into doing all of this a little piece at a time. :-)

This should address everything mentioned in #1146. I was able to get a string out of the link just using things built into BeautifulSoup without the webscraping module.

skurfer
Copy link
Member Author

@skurfer skurfer commented on bec6d9b Oct 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s a head-start on #1146 @pjrobertson. The random order was really wearing on me. :-) You should be able to grab this branch and push the rest of your changes to it.

skurfer added 3 commits Oct 2, 2012
It converts HTML entities to UTF-8 characters automatically
Instead of only checking `<a><span>Text</span></a>`, this should also handle things like

    <a><b>Text</b></a>
    <a><b><i>Text</i></b></a>
    <a><b><i>More</i> Text</b> Here</a>

and so on.
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 4, 2012

Hehe, I did well to trick you into doing this. I knew your Python fingers wouldn't be able to resist ;-)

Merged

pjrobertson added a commit that referenced this issue Oct 4, 2012
@pjrobertson pjrobertson merged commit 45c8910 into master Oct 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants