Resource manager #1156

Merged
merged 3 commits into from Oct 5, 2012

Conversation

Projects
None yet
2 participants
Owner

skurfer commented Oct 5, 2012

As part of #1128, we created a new way to specify resources according to OS version. It turns out there was already a way to handle this. You just give an array of resources and all of them will be tried until one is found. That's a bit slower as it has to go to disk while it iterates through the potential resources, but it's much easier on developers since they don't have to keep up a bunch of OS-specific keys.

I've reverted the changes and defined the printer icon as an array instead.

Owner

pjrobertson commented Oct 5, 2012

So we're back to the method I suggested? Wahey! :P

Were there any other resources that had the new format? I seems to remember a removable disks one, or did you change that for everyone?

Owner

skurfer commented Oct 5, 2012

Were there any other resources that had the new format? I seems to remember a removable disks one, or did you change that for everyone?

No, we found one that everyone has.

Owner

pjrobertson commented Oct 5, 2012

Cool, merged

pjrobertson added a commit that referenced this pull request Oct 5, 2012

@pjrobertson pjrobertson merged commit fb775c1 into master Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment