Finder plugin cleanup #1169

Merged
merged 6 commits into from Oct 30, 2012

Projects

None yet

2 participants

@skurfer
Member
skurfer commented Oct 12, 2012

This should fix #683, as well as some other small things.

@pjrobertson
Member

Hmmm... I still get exactly the same problem as I showed here:
#683 (comment)

I've cleared caches, removed and readded the Finder sidebar items etc. etc. to no avail.
Upon further inspection, any new item I add is put under com.apple.sidebarlists > favorites > VolumesList
Here's an example:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>Icon</key>
    <data>SW1nUgAAASYAAAAARkJJTAAAARoAAAACAAAAAAAAAAABCgADAAAAAMkJBvkAAEgrAAAAAACEEFMBjaMzAADMEwTBAAAAAAkg//4AAAAAAAAAAP////8AAQAYAIQQUwCEDl8AhA5eAIQFlwCEBYoAhAWJAA4ALgAWAEcAZQBuAGUAcgBpAGMARgBvAGwAZABlAHIASQBjAG8AbgAuAGkAYwBuAHMADwAaAAwATQBhAGMAaQBuAHQAbwBzAGgAIABIAEQAEgBWU3lzdGVtL0xpYnJhcnkvQ29yZVNlcnZpY2VzL0NvcmVUeXBlcy5idW5kbGUvQ29udGVudHMvUmVzb3VyY2VzL0dlbmVyaWNGb2xkZXJJY29uLmljbnMAEwABLwD//wAA</data>
    <key>CustomItemProperties</key>
    <dict>
        <key>com.apple.LSSharedFileList.TemplateSystemSelector</key>
        <integer>1935820388</integer>
    </dict>
    <key>Name</key>
    <string>logos_09</string>
    <key>Alias</key>
    <data>AAAAAACkAAMAAQAAyQkG+QAASCsAAAAAAAWr3AGYhjIAAMyQqnYAAAAACSD//gAAAAAAAAAA/////wABAAgABavcAACRnwAOABIACABsAG8AZwBvAHMAXwAwADkADwAaAAwATQBhAGMAaQBuAHQAbwBzAGgAIABIAEQAEgAWVXNlcnMvcGF0cmljay9sb2dvc18wOQATAAEvAAAVAAIADv//AAA=</data>
</dict>
</plist>
@skurfer
Member
skurfer commented Oct 25, 2012

Upon further inspection, any new item I add is put under com.apple.sidebarlists > favorites > VolumesList

The location it currently refers to is showing the correct items for me, but that list hasn't changed in a very long time. I see that if I add something new like ~/Music, it doesn't appear there. It does appear in the location you refer to, but so do 220 other things. It seems to contain a large number of CD's, DMG's, network volumes, etc. that haven't been present in months. Adding all that noise wouldn't be ideal. Is that not the case on your system?

@skurfer
Member
skurfer commented Oct 25, 2012

I tried that path, and it appears to show almost the things we want. It has the current list of sidebar items (as of the last time the plist was written) and only 11 things total, so most of the noise is ignored somehow. But in addition to the stuff that should be there, it also shows /, /Network, and any currently mounted volumes.

@skurfer
Member
skurfer commented Oct 25, 2012

New commit. Try it out now.

@pjrobertson
Member

OK so we're still not quite there...

  • The entry always disables itself whenever I relaunch QS. Not sure why.
@pjrobertson
Member

EDIT:

OK ignore the 1st part, but the catalog entry still disables itself.
Also, there are only meant to be 2 entries now right?
http://cl.ly/image/0s1D1Q3K2K3m

@skurfer
Member
skurfer commented Oct 26, 2012

The entry always disables itself whenever I relaunch QS. Not sure why.

Because changes to the catalog are basically never saved for some reason. In my case, it always enables itself. Were you not aware of that? :-)

Also, there are only meant to be 2 entries now right?

Yes. See 8b50d5e

http://cl.ly/image/0s1D1Q3K2K3m

Cloud, eh? I started using it last week and am already working on a plug-in. :-) Well, I was. Remember what I said about hating compilers and headers?

@pjrobertson
Member

Cloud, eh? I started using it last week and am already working on a
plug-in. :-) Well, I was. Remember what I said about hating compilers and
headers?

The 'Upload with Cloud' service is really useful, I fixed the Services
plugin not too long ago so that would work. Just started using it properly
myself. Think it's better than droplr.

Because changes to the catalog are basically never saved for some reason.
In my case, it always enables itself. Were you not aware of that? :-)

I was aware of this as of yesterday, does that count? :) Is it recent? most
likely caused by one of my changes to try and stop a crash with writing
catalog entries.

On 26 October 2012 13:54, Rob McBroom notifications@github.com wrote:

The entry always disables itself whenever I relaunch QS. Not sure why.

Because changes to the catalog are basically never saved for some reason.
In my case, it always enables itself. Were you not aware of that? :-)

Also, there are only meant to be 2 entries now right?

Yes. See 8b50d5ehttps://github.com/quicksilver/Quicksilver/commit/8b50d5e

http://cl.ly/image/0s1D1Q3K2K3m

Cloud, eh? I started using it last week and am already working on a
plug-in. :-) Well, I was. Remember what I said about hating compilers and
headers?


Reply to this email directly or view it on GitHubhttps://github.com/quicksilver/Quicksilver/pull/1169#issuecomment-9811897.

@skurfer
Member
skurfer commented Oct 26, 2012

The 'Upload with Cloud' service is really useful, I fixed the Services plugin not too long ago so that would work.

Ah, didn't realize it had a service. That's good for uploads, but I'd also like to be able to add objects for uploaded items to the catalog (and show them as children for the app), recommend the plug-in if the app is installed, allow you to remove uploads, toggle privacy, copy the URL again, etc. You wouldn't even need the app installed at that point. :-)

I was aware of this as of yesterday, does that count? :) Is it recent?

Not sure exactly, but I feel like it's pretty old. Introduced in B69 perhaps? Maybe sooner.

@pjrobertson pjrobertson merged commit c697da7 into master Oct 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment