Large type plain text #1185

Merged
merged 3 commits into from Oct 29, 2012

2 participants

@pjrobertson
Quicksilver OS X member

First off, this pull means actions are now validated based on whether the file's UTI (in the 1st pane) conforms to the directFileTypes UTI (if one is defined of course) as opposed to just an exact match.

Example:
Set directFileTypes for a action XXX to public.text.
Select a PHP file in the 1st pane (which has a UTI of public.php-script but conforms to public.text) and action XXX will appear for this

The reason I did this was so that 'Large Type' would appear for plain text files, so you can now use 'File
→ Large Type' as an equivalent to Terminal's cat file.php

@skurfer
Quicksilver OS X member

Looks good. I was going to suggest adding com.apple.finder.textclipping to the list of UTI's but it doesn't seem to work. initWithContentsOfFile: must not like Text Clippings.

FYI, when I was in there adding the additional UTI in TextMate, I noticed a trailing tab after <string>public.plain-text</string>. Doesn't seem to cause any problems, but we should probably take it out.

@pjrobertson
Quicksilver OS X member

Sorry never said - I'd removed the stray tab a couple of days ago

@skurfer
Quicksilver OS X member

Sorry never said - I'd removed the stray tab a couple of days ago

I knew about it. I think you mentioned it on IRC. Anyway, merging.

@skurfer skurfer merged commit 59fa691 into quicksilver:master Oct 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment