Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large type plain text #1185

Merged
merged 3 commits into from Oct 29, 2012
Merged

Large type plain text #1185

merged 3 commits into from Oct 29, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 25, 2012

First off, this pull means actions are now validated based on whether the file's UTI (in the 1st pane) conforms to the directFileTypes UTI (if one is defined of course) as opposed to just an exact match.

Example:
Set directFileTypes for a action XXX to public.text.
Select a PHP file in the 1st pane (which has a UTI of public.php-script but conforms to public.text) and action XXX will appear for this

The reason I did this was so that 'Large Type' would appear for plain text files, so you can now use 'File
→ Large Type' as an equivalent to Terminal's cat file.php

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 25, 2012

Looks good. I was going to suggest adding com.apple.finder.textclipping to the list of UTI's but it doesn't seem to work. initWithContentsOfFile: must not like Text Clippings.

FYI, when I was in there adding the additional UTI in TextMate, I noticed a trailing tab after <string>public.plain-text</string>. Doesn't seem to cause any problems, but we should probably take it out.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Oct 27, 2012

Sorry never said - I'd removed the stray tab a couple of days ago

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 29, 2012

Sorry never said - I'd removed the stray tab a couple of days ago

I knew about it. I think you mentioned it on IRC. Anyway, merging.

skurfer added a commit that referenced this issue Oct 29, 2012
@skurfer skurfer merged commit 59fa691 into quicksilver:master Oct 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants