remove the 'Run [...]' action from the core plugin (it's in the Terminal Plugin) #1199
Conversation
…nal Plugin) I have left the command formats/descriptions in the respective .strings file for future reference (when localising the action in the Terminal plugin) Aside: This action was very confusing as it had '[...]' in the name but did not accept indirect args (that is the one in the Terminal Plugin :/)
| @@ -139,13 +139,6 @@ - (NSArray *)validActionsForDirectObject:(QSObject *)dObject indirectObject:(QSO | |||
| return nil; | |||
| } | |||
|
|
|||
| - (QSObject *)runShellScript:(QSObject *)dObject { | |||
| NSString *result = [self runScript:[dObject singleFilePath]]; | |||
There was a problem hiding this comment.
So is anything using runScript: now?
|
Does the one in the Terminal plug-in override this one? I couldn't even find it in my list of actions until I disabled Terminal. Which on (in the Terminal plug-in) replaces it? |
The Run […] action in the Terminal plugin overrides it. Hence the The one in the Terminal plugin is better, as it allows for an indirect obj On 8 November 2012 15:45, Rob McBroom notifications@github.com wrote:
|
It was defined but had no actionSelector.
remove the 'Run [...]' action from the core plugin (it's in the Terminal Plugin)
Fixes #795
I have left the command formats/descriptions in the respective .strings file for future reference (when localising the action in the Terminal plugin)
Aside: This action was very confusing as it had '[...]' in the name but did not accept indirect args (that is the one in the Terminal Plugin :/)