Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the 'Run [...]' action from the core plugin (it's in the Terminal Plugin) #1199

Merged
merged 3 commits into from Nov 12, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 8, 2012

Fixes #795

I have left the command formats/descriptions in the respective .strings file for future reference (when localising the action in the Terminal plugin)

Aside: This action was very confusing as it had '[...]' in the name but did not accept indirect args (that is the one in the Terminal Plugin :/)

…nal Plugin)

I have left the command formats/descriptions in the respective .strings file for future reference (when localising the action in the Terminal plugin)

Aside: This action was very confusing as it had '[...]' in the name but did not accept indirect args (that is the one in the Terminal Plugin :/)
@@ -139,13 +139,6 @@ - (NSArray *)validActionsForDirectObject:(QSObject *)dObject indirectObject:(QSO
return nil;
}

- (QSObject *)runShellScript:(QSObject *)dObject {
NSString *result = [self runScript:[dObject singleFilePath]];
Copy link
Member

@skurfer skurfer Nov 8, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is anything using runScript: now?

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 8, 2012

Does the one in the Terminal plug-in override this one? I couldn't even find it in my list of actions until I disabled Terminal. Which on (in the Terminal plug-in) replaces it?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 8, 2012

Which on (in the Terminal plug-in) replaces it?

The Run […] action in the Terminal plugin overrides it. Hence the
weirdness. Two actions with the same name, both coming from different
places. I think QS got confused over what to do.

The one in the Terminal plugin is better, as it allows for an indirect obj
(optional)

On 8 November 2012 15:45, Rob McBroom notifications@github.com wrote:

Does the one in the Terminal plug-in override this one? I couldn't even
find it in my list of actions until I disabled Terminal. Which on (in the
Terminal plug-in) replaces it?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1199#issuecomment-10192535.

skurfer added a commit that referenced this issue Nov 12, 2012
remove the 'Run [...]' action from the core plugin (it's in the Terminal Plugin)
@skurfer skurfer merged commit 562c644 into quicksilver:master Nov 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants