remove the 'Run [...]' action from the core plugin (it's in the Terminal Plugin) #1199

Merged
merged 3 commits into from Nov 12, 2012

2 participants

@pjrobertson
Quicksilver OS X member

Fixes #795

I have left the command formats/descriptions in the respective .strings file for future reference (when localising the action in the Terminal plugin)

Aside: This action was very confusing as it had '[...]' in the name but did not accept indirect args (that is the one in the Terminal Plugin :/)

@pjrobertson pjrobertson remove the 'Run [...]' action from the core plugin (it's in the Termi…
…nal Plugin)

I have left the command formats/descriptions in the respective .strings file for future reference (when localising the action in the Terminal plugin)

Aside: This action was very confusing as it had '[...]' in the name but did not accept indirect args (that is the one in the Terminal Plugin :/)
a37e79e
@pjrobertson pjrobertson referenced this pull request in quicksilver/Terminal-qsplugin Nov 8, 2012
Merged

Small tidy ups #8

@skurfer skurfer commented on the diff Nov 8, 2012
...ugIns-Main/QSCorePlugIn/Code/QSShellScriptRunAction.m
@@ -139,13 +139,6 @@ - (NSArray *)validActionsForDirectObject:(QSObject *)dObject indirectObject:(QSO
return nil;
}
-- (QSObject *)runShellScript:(QSObject *)dObject {
- NSString *result = [self runScript:[dObject singleFilePath]];
@skurfer
Quicksilver OS X member
skurfer added a note Nov 8, 2012

So is anything using runScript: now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@skurfer
Quicksilver OS X member

Does the one in the Terminal plug-in override this one? I couldn't even find it in my list of actions until I disabled Terminal. Which on (in the Terminal plug-in) replaces it?

@pjrobertson
Quicksilver OS X member
@skurfer skurfer merged commit 562c644 into quicksilver:master Nov 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment