GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Who'd have thought it would be such an easy fix.
I'm not sure why we were attempting to re-creating an existing QSCommand object (in QSHistoryController.m:L49) and doing so incorrectly!
Looks like afb1023 added the objectValue method (not sure what it does, @tiennou ?)
and … good old Code Cleanup 2b08e42 is as far back as I can go for QSHistoryController.m, but looks like that didn't actually change anything.
A few other tidy ups:
- (void)addCommand:(QSCommand *)command
Don't attempt to re-format existing command objects. Fixes #555. Fixes …
Sorry, this doesn't fix #722, which is already fixes. It semi resolves #1115 (I hope I avoided GH's automagical closing system there :D )
And I can confirm that this does fix #905 as @skurfer suggested.
Although using the comma trick on command objects doesn't work… but that's another issue ;-)
Change the method decleration for addCommand in the header file
Of the things listed in #1115, what does this not fix? I now seem to be able to use Recent Commands and the Last Command proxy object. Nice work!
Merge pull request #1207 from pjrobertson/commandObjects
Don't attempt to re-format existing command objects. Fixes #555. Fixes #722