Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to re-format existing command objects. Fixes #555. Fixes #722 #1207

Merged
merged 2 commits into from Nov 28, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 13, 2012

Who'd have thought it would be such an easy fix.

I'm not sure why we were attempting to re-creating an existing QSCommand object (in QSHistoryController.m:L49) and doing so incorrectly!

Looks like afb1023 added the objectValue method (not sure what it does, @tiennou ?)
and … good old Code Cleanup 2b08e42 is as far back as I can go for QSHistoryController.m, but looks like that didn't actually change anything.

A few other tidy ups:

  • Don't know why(id) was used in QSHistoryController for - (void)addCommand:(QSCommand *)command. It's always a QSCommand so I've changed this
  • If the 'last command' proxy was run, there's no point adding this command (or it's resolved command) to the catalog, the 'last command' will always be the 'last command' until a different command is run. Confusing? ;-)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 13, 2012

Sorry, this doesn't fix #722, which is already fixes. It semi resolves #1115 (I hope I avoided GH's automagical closing system there :D )

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 13, 2012

And I can confirm that this does fix #905 as @skurfer suggested.

Although using the comma trick on command objects doesn't work… but that's another issue ;-)

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 20, 2012

Of the things listed in #1115, what does this not fix? I now seem to be able to use Recent Commands and the Last Command proxy object. Nice work!

skurfer added a commit that referenced this issue Nov 28, 2012
Don't attempt to re-format existing command objects. Fixes #555. Fixes #722
@skurfer skurfer merged commit 230b304 into quicksilver:master Nov 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants