Don't attempt to re-format existing command objects. Fixes #555. Fixes #722 #1207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Who'd have thought it would be such an easy fix.
I'm not sure why we were attempting to re-creating an existing QSCommand object (in QSHistoryController.m:L49) and doing so incorrectly!
Looks like afb1023 added the
objectValue
method (not sure what it does, @tiennou ?)and … good old Code Cleanup 2b08e42 is as far back as I can go for QSHistoryController.m, but looks like that didn't actually change anything.
A few other tidy ups:
(id)
was used in QSHistoryController for- (void)addCommand:(QSCommand *)command
. It's always aQSCommand
so I've changed this