Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: Save the infoRecord flags as an unsigned long (not unsigned int) #1211

Merged
merged 2 commits into from Nov 14, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 14, 2012

This fixes the ability to right arrow into alias objects.

Also: a fix for getting children of an alias object

To produce the problem with the current HEAD:

  • try and browse into /tmp/QS. You can't get into /tmp (as it's an alias to /private/tmp)
  • Or: create an alias for a file/folder/application on your desktop and try and right arrow into it

Also - fix getting children of an alias object
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 14, 2012

There's another commit on the end here which fixes the open with… action for cases when there may not be a default app.

@tiennou
Copy link
Member

@tiennou tiennou commented Nov 14, 2012

Looks good to me. I'll be running with it a little while.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 14, 2012

FWIW I tested in 32 and 64 bit mode of QS and it works. I figured that
storing an unsigned int as an unsigned long won't cause any harm (except
you use twice as much memory ;-) ) but doing it the other way round will
break things.

On 14 November 2012 14:52, Etienne Samson notifications@github.com wrote:

Looks good to me. I'll be running with it a little while.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1211#issuecomment-10368564.

skurfer added a commit that referenced this issue Nov 14, 2012
URGENT: Save the infoRecord flags as an unsigned long (not unsigned int)
@skurfer skurfer merged commit f089f5d into quicksilver:master Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants