Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringstool #1222

Merged
merged 14 commits into from Sep 17, 2013
Merged

Stringstool #1222

merged 14 commits into from Sep 17, 2013

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Nov 18, 2012

The much needed script to update our strings files from XIBs. Feel free to cherry-pick the first one and drop the second one.

I'm lurking on IRC too, if you can read that soon enough ;-).

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 19, 2012

wooooooh awesome!

Just had someone ask on Transifex why all the strings weren't available. I told him to wait a little ;-)

Can we have some kind of 'ignores' list for words that shouldn't be translated (like cpio, tgz, item1, item2)

Also, looks like there are some duplicates in the .strings files.
Can we make the script only add each string once?
tiennou@55f0413#L16R35

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 19, 2012

Can we have some kind of 'ignores' list for words that shouldn't be translated (like cpio, tgz, item1, item2)

Box? Button? Are those really visible to the user, or just present in the NIB somewhere? And would the NIB break if they changed?

@tiennou
Copy link
Member Author

@tiennou tiennou commented Nov 19, 2012

@pjrobertson: Good idea ;-). I'll add a --ignore-keys flags that takes regular expressions.

@skurfer: Not sure. ibtool ought to export every string it can find, even those that aren't displayed (like NSBoxes without a title, which show up as Box). And no, I don't think they can break the NIB anyway. I'll do the ignore thing to drop those.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 19, 2012

I'll add a --ignore-keys flags that takes regular expressions.

…actually, no! Can we hard code it, or make an ignores file? Every time we
run this script, I don't think we should have to remember which strings
need ignoring :P

On 19 November 2012 19:12, Etienne Samson notifications@github.com wrote:

@pjrobertson https://github.com/pjrobertson: Good idea ;-). I'll add a
--ignore-keys flags that takes regular expressions.

@skurfer https://github.com/skurfer: Not sure. ibtool ought to export
every string it can find, even those that aren't displayed (like NSBoxes
without a title, which show up as Box). And no, I don't think they can
break the NIB anyway. I'll do the ignore thing to drop those.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1222#issuecomment-10526554.

@tiennou
Copy link
Member Author

@tiennou tiennou commented Nov 19, 2012

I was wondering about that too... I thought of the ignore file, and couldn't think of a good-enough name ;-). No, the problem was more where to put it. I thought about hard coding, but I don't like "magic values", and in fact I want that stringstool to be kept general (in case someone else finds a use for it :hint: ;-)). Maybe a simple update_localization.sh script wrapping it with the correct arguments for our use ?

Also, is there anything else you think it should do ? I had planned to do the "merge" thing, but now I'm not sure it would be that useful (for us that is, see this for inspiration).

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 15, 2013

Yeah, I think if you

  • Add an ignores option
  • Make sure duplicate strings don't get added to the same .string file
  • wrap everything in a localization.sh file
  • Would it be possible to flag up 'changes' to any of the strings. E.g. say we change a string "Update Quicksilver" to "Updating Quicksilver", is there any way we can flag this, so that we can deal with all the localizations that use "Update Quicksivler" = "Diweddaru Quicksilver"; in every language (that's Welsh btw ;-) )

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 12, 2013

Yay ! @pjrobertson I reverted my commit on English strings, so this can get merged in. I'm not even sure you were using it in the first place ;-).

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 13, 2013

I hope you got that merge into master right ;-) It's been a looooong time!

You're right, I haven't been using it - mainly because of the duplicates thing and the ignores thing. But I guess we could use it now. Transifex needs to be updated with all our latest localisations :)

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 13, 2013

Yeah, I think I did. Since working with the wondrous GitHubbers on Objective-Git, I'm trying to cut down on rebases ;-). If you don't mind, I'll do a more thorough check of strings that still miss translations in the main code, and then Transifex can get its update. And there are string I want to fix : someone changed "Show in Large Type" from "Afficher en grand" to "Grande police" (a.k.a "Large Type"), which doesn't make sense as an action and broke my internal mnemonics...

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 17, 2013

Merging because well, it's just a tool ;-).

tiennou added a commit that referenced this issue Sep 17, 2013
@tiennou tiennou merged commit 4481b58 into quicksilver:master Sep 17, 2013
@tiennou tiennou deleted the stringstool branch Sep 17, 2013
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 17, 2013

someone changed "Show in Large Type" from "Afficher en grand" to "Grande police"

Lol!
The merge is fine with me. Sorry for being slow ;)

On 13 Medi 2013, at 19:58, Etienne Samson notifications@github.com wrote:

Yeah, I think I did. Since working with the wondrous GitHubbers on Objective-Git, I'm trying to cut down on rebases ;-). If you don't mind, I'll do a more thorough check of strings that still miss translations in the main code, and then Transifex can get its update. And there are string I want to fix : someone changed "Show in Large Type" from "Afficher en grand" to "Grande police" (a.k.a "Large Type"), which doesn't make sense as an action and broke my internal mnemonics...


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants