Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent search strings from being applied to history #1231

Merged
merged 2 commits into from Nov 20, 2012
Merged

prevent search strings from being applied to history #1231

merged 2 commits into from Nov 20, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Nov 20, 2012

Rework of #1226

This fixes two visual oddities:

  1. If you search for s, then start going back through your history, any object with s in the name or label would have that character underlined.
  2. Some objects, like Safari, would always appear in the history with both name and label visible, as in “Safari ⟷ Safari.app”. This would happen unconditionally (not just when the active search string matched something in the name).

There seem to be 5 different methods to “reset” the search string in this class, but I think I’ve selected the correct one. I've tried to clarify some of them with comments in the header.

Note that this is a pull against the release branch. It should be merged it to master too, when the time comes.

skurfer added 2 commits Nov 20, 2012
Seemingly random characters won't be underlined, and the name won't appear along with the label.
pjrobertson added a commit that referenced this issue Nov 20, 2012
prevent search strings from being applied to history
@pjrobertson pjrobertson merged commit e81e317 into quicksilver:release Nov 20, 2012
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 20, 2012

Since you have the branch, feel free to merge into master :)

skurfer added a commit that referenced this issue Nov 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants