Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure docking windows close when the x button is pressed #1247

Merged
merged 1 commit into from Nov 27, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 27, 2012

A rework of #1237. See there for details.

We need the window to become key when events are sent to it so that things like clicking the 'x' button works.
Are we working round an OS X bug? I think that's normal now :)

@skurfer
Copy link
Member

skurfer commented Nov 27, 2012

For the first time in memory, I think these windows operate correctly. Well done. :-)

skurfer added a commit that referenced this pull request Nov 27, 2012
make sure docking windows close when the x button is pressed
@skurfer skurfer merged commit a075cc6 into quicksilver:master Nov 27, 2012
@skurfer
Copy link
Member

skurfer commented Nov 27, 2012

And with that merge, I need to start keeping track of changes for the next release. Note the optimism in the title. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants