Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two dangling actions. Fixes #1242 #1252

Merged
merged 1 commit into from Nov 29, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 28, 2012

These actions have caused confusion for lots of users, especially as the 'FinderOpenTrashAction' has the name 'Open' and works on all objects.

This is based against release, since quite a few users have reported problems with the 'open' action in ß71. Most likely due to the real Open action being localised, but this one not.

@skurfer
Copy link
Member

skurfer commented Nov 28, 2012

Did you try just removing the QSActions section completely? Does that cause problems?

@pjrobertson
Copy link
Member Author

pjrobertson commented Nov 29, 2012

No, I didn't try that. And I don't really know why :P

I've pushed a new commit that removes the dict complety (I've rewritten history, I hope the historians don't get mad)

@skurfer
Copy link
Member

skurfer commented Nov 29, 2012

The historians can easily delete and recreate the branch. :-) I'll try it out.

skurfer added a commit that referenced this pull request Nov 29, 2012
Remove two dangling actions. Fixes #1242
@skurfer skurfer merged commit 2537054 into quicksilver:release Nov 29, 2012
skurfer added a commit that referenced this pull request Nov 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants