Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

file preview efficiency #1297

Merged
merged 1 commit into from Dec 20, 2012

Conversation

Projects
None yet
2 participants
Owner

skurfer commented Dec 17, 2012

The fallback value when no preview image is available for a file object was the "regular" icon from NSWorkspace. But it occurred to me that the regular icon is what gets used as the initial value while the background thread goes and looks for something better. If nothing better is found, there's no sense falling back to the icon that's already set and forcing the UI to redraw.

This should cut down on a ton of QSObjectIconModified notifications.

@skurfer skurfer only replace file icons if a better one was found
The icon from NSWorkspace will be set before this method is called. No
need to replace the image with itself.
012f2e9

@pjrobertson pjrobertson added a commit that referenced this pull request Dec 20, 2012

@pjrobertson pjrobertson Merge pull request #1297 from skurfer/previewEfficiency
file preview efficiency
d119136

@pjrobertson pjrobertson merged commit d119136 into quicksilver:master Dec 20, 2012

@skurfer skurfer deleted the skurfer:previewEfficiency branch Dec 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment