Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file preview efficiency #1297

Merged
merged 1 commit into from Dec 20, 2012
Merged

file preview efficiency #1297

merged 1 commit into from Dec 20, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Dec 17, 2012

The fallback value when no preview image is available for a file object was the "regular" icon from NSWorkspace. But it occurred to me that the regular icon is what gets used as the initial value while the background thread goes and looks for something better. If nothing better is found, there's no sense falling back to the icon that's already set and forcing the UI to redraw.

This should cut down on a ton of QSObjectIconModified notifications.

The icon from NSWorkspace will be set before this method is called. No
need to replace the image with itself.
pjrobertson added a commit that referenced this issue Dec 20, 2012
@pjrobertson pjrobertson merged commit d119136 into quicksilver:master Dec 20, 2012
@skurfer skurfer deleted the previewEfficiency branch Dec 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants