Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat current selection as a string when type is unknown #1311

Merged
merged 1 commit into from Feb 1, 2013
Merged

treat current selection as a string when type is unknown #1311

merged 1 commit into from Feb 1, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jan 4, 2013

I'm not sure what the thinking was behind these defaults. The history credits it to the "Code cleanup" commit. :-(

Anyway, I see no reason to include the file type. The value for it is empty anyway, and in situations where the Current Selection proxy should have a file type, it does without this default (tested in Finder and Path Finder).

The reason for this change is that the "Find With…" action wouldn't appear for Current Selection. The Web Search plug-in only allows that action for objects with the text type, but no file type.

If anyone is uncomfortable with this change, there are at least two other ways to fix it in the plug-in instead:

  1. Instead of just checking for the presence of the file type, maybe test validSingleFilePath instead. So if it's just a blank dummy type, it won't prevent the action from appearing.
  2. Allow the "Find With…" action for files. Hey, maybe someone has a need to search the web for the string "~/Library/Application Support". :-)

pjrobertson added a commit that referenced this issue Feb 1, 2013
treat current selection as a string when type is unknown
@pjrobertson pjrobertson merged commit ceab828 into quicksilver:master Feb 1, 2013
@skurfer skurfer deleted the selectionTypes branch Feb 10, 2013
@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 10, 2013

This also fixes #1071 and possibly #766.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants