New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisations #1335
Optimisations #1335
Conversation
Don't use Gzip compression for the QSUrlParser, since it's actually slower
* Do not close/open the 3rd pane for indirect optional actions when in text mode in the 1st pane (e.g. create Calendar To-Do) * Pop history off stack when browsing ← * Optimisations
Looks like good stuff. One small thing I've seen in brief testing is that the action icon goes dim after a few seconds. Going to the second pane and hitting ↓ makes it look "normal" again. If you're bored, here are some other small fixes we could add to this:
|
Figured this one out. The status string is only updated if the selection changes. We might need to define a method to generate that string and call it for both selection changes and array changes (by overriding the setter for |
Also - rename some vars (they're sets, NOT arrays!) and use blocks for getting vals
I'll fix the two things I mentioned in another branch. Are you going to do as @tiennou suggested:
I haven't looked to see if there are any places where that needs to be done. |
I checked through them yesterday, but couldn't see any extra calls to Another commit with a few more changes. There are 1 or 2 methods which I haven't touched ( |
It's argued that this is easier to read
Metadata is only ever stored in the 'meta' dict (not the 'data' dict), so only check there for object properties
Most of the information is in each commit message.
The reason I decided to GZip the requests to QSApp is to reduce bandwidth usage.
We can save quite a bit, for example on the plugins info .xml (from here)
GZip support isn't documented, bit I've used it fine in iOS.
The other changes:
Lots of these commits are from a stash made a while back, and 'optimisations' can always be too optimistic, so it's worth keeping a close eye when running with this pull