Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'resolvesProxy' bool for actions that shouldn't resolve proxies. Fixes #1342 #1343

Merged
merged 1 commit into from Jan 23, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 22, 2013

After a recent change (cd54162) all objects were being resolved before being sent to actions.
This shouldn't happen in some cases (e.g. assign abbreviation)

As discussed in IRC.
If anybody can think of any other actions where this should be the case, let me know

…Fixes quicksilver#1342

After a recent change (cd54162) all objects were being resolved before being sent to actions.
This shouldn't happen in some cases (e.g. assign abbreviation)
@@ -0,0 +1 @@
Subproject commit f569e60e9e46220bce701dcfe7b92f4d8abe01ad
Copy link
Member

@skurfer skurfer Jan 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are hell bent on getting this into master, huh? ;-)

Copy link
Member Author

@pjrobertson pjrobertson Jan 22, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God dammit yes :P

Maybe I should just have one long pull request where I put all my stuff to avoid this? :D

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 23, 2013

Not really related to this commit, but something I ran across in testing…

The Assign Abbreviation action doesn't appear to actually add anything under abbreviation in the plist. It adds the new thing under implied, and maybe that's sufficient, but it seems weird. Here's what I mean. Assuming I don't have "cs" anywhere in Mnemonics.plist

  1. Locate Current Selection (using some string other than "cs")
  2. Run "Assign Abbreviation…" and enter "cs"
  3. abbreviation → cs doesn't exist. implied → QSGlobalSelectionProxy → cs will have a value of 1.
  4. Locate "Current Selection" by typing "cs"
  5. Run an action on it
  6. abbreviation → cs points to QSGlobalSelectionProxy. implied → QSGlobalSelectionProxy → cs will have a value of 2.

Seems like the abbreviation entry should be added right away. Is it in memory, but not in the file or something?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 23, 2013

I don't really follow what you've said. I think you've a much better idea of abbreviations than me, so can I let you do it? :)

skurfer added a commit that referenced this issue Jan 23, 2013
Add a 'resolvesProxy' bool for actions that shouldn't resolve proxies. Fixes #1342
@skurfer skurfer merged commit dc788ba into quicksilver:master Jan 23, 2013
@skurfer
Copy link
Member

@skurfer skurfer commented Jan 23, 2013

That was a punt, right there. :-)

@pjrobertson pjrobertson deleted the resolvesProxy branch Jan 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants