Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little things #1346

Merged
merged 4 commits into from Jan 24, 2013
Merged

Little things #1346

merged 4 commits into from Jan 24, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 23, 2013

See #1344 for more details.

I've added a commit to fix a few warnings.
I decided not to do what I said here since we only ever reach this method if the urlString is recognised as a URL, and at the moment that means if it has the mailto: prefix or a scheme.

@skurfer
Copy link
Member

skurfer commented Jan 24, 2013

we only ever reach this method if the urlString is recognised as a URL, and at the moment that means if it has the mailto: prefix or a scheme.

Good point. So let's leave it as is for now.

Long term… I noticed DefaultApp has a list of all the URL protocols on the system somehow. Not sure if it's a hard-coded list or if it can be discovered, but maybe we could do something similar and just check to see if the stuff before a : is on the list.

Anything else that needs to go in here?

@pjrobertson
Copy link
Member Author

pjrobertson commented Jan 24, 2013

I noticed DefaultApp has a list of all the URL protocols

Interesting. My guess is it's hard coded, but that's a complete guess :)

Anything else that needs to go in here?

Not from my end (until I find something else!). The UTF-8/16 business I mentioned seemed to disappear (or at least UTF-16 was already set on the files so I don't understand the warnings)

skurfer added a commit that referenced this pull request Jan 24, 2013
@skurfer skurfer merged commit 5cbbeb2 into master Jan 24, 2013
@skurfer skurfer deleted the littleThings branch Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants