Little things #1346

Merged
merged 4 commits into from Jan 24, 2013

Projects

None yet

2 participants

@pjrobertson
Quicksilver OS X member

See #1344 for more details.

I've added a commit to fix a few warnings.
I decided not to do what I said here since we only ever reach this method if the urlString is recognised as a URL, and at the moment that means if it has the mailto: prefix or a scheme.

@skurfer
Quicksilver OS X member

we only ever reach this method if the urlString is recognised as a URL, and at the moment that means if it has the mailto: prefix or a scheme.

Good point. So let's leave it as is for now.

Long term… I noticed DefaultApp has a list of all the URL protocols on the system somehow. Not sure if it's a hard-coded list or if it can be discovered, but maybe we could do something similar and just check to see if the stuff before a : is on the list.

Anything else that needs to go in here?

@pjrobertson
Quicksilver OS X member

I noticed DefaultApp has a list of all the URL protocols

Interesting. My guess is it's hard coded, but that's a complete guess :)

Anything else that needs to go in here?

Not from my end (until I find something else!). The UTF-8/16 business I mentioned seemed to disappear (or at least UTF-16 was already set on the files so I don't understand the warnings)

@skurfer skurfer merged commit 5cbbeb2 into master Jan 24, 2013
@skurfer skurfer deleted the littleThings branch Jan 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment