Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #1357

Merged
merged 8 commits into from Feb 1, 2013
Merged

Small fixes #1357

merged 8 commits into from Feb 1, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 29, 2013

A running pull request with any 'small' fixes.
It initially started to fix #1353, but I've added various other things over time

pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented on 83d5cd9 Jan 29, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes, if you used space to flip to the argument field (make sure said setting is enabled in command prefs) the 3rd pane wouldn't go to text mode. This fixes it.

Reproduce the problem:

Google search ␣ (space) type somthing
reopen QS
hit ␣ (space) immediately. 3rd pane doesn't go to text mode (not always reproducible?)

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 31, 2013

"Save Command to File…" should only show folders the same way "Move To…" does. I can fix it, just not right now. Leaving this here as a reminder.

And maybe it should be say "to Folder". :-)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 31, 2013

I see what you did there ;-)

It was so easy I couldn't resist, and just incase we all forgot I thought
I'd do it now.

I used the home folder as the default folder. Seemed like a reasonable
option to me

On 31 January 2013 14:16, Rob McBroom notifications@github.com wrote:

"Save Command to File…" should only show folders the same way "Move To…"
does. I can fix it, just not right now. Leaving this here as a reminder.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1357#issuecomment-12944073.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 31, 2013

P.S. - I picked up a bug with this code. Something else to fix, I can do it but just not right now ;-)

If currentFolderPath is nil, [NSNull null] gets used instead, which throws an exception later on down the line:

2013-01-31 14:25:25.948 Quicksilver[27659:303] -[NSNull loadIcon]: unrecognized selector sent to instance 0x7fff7c331310
2013-01-31 14:25:25.951 Quicksilver[27659:303] (
    0   CoreFoundation                      0x00007fff9339c0a6 __exceptionPreprocess + 198
    1   libobjc.A.dylib                     0x00007fff931ca3f0 objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff93430229 -[NSException raise] + 9
    3   ExceptionHandling                   0x00000001002b465b NSExceptionHandlerExceptionRaiser + 210
    4   libobjc.A.dylib                     0x00007fff931ca3f0 objc_exception_throw + 43
    5   CoreFoundation                      0x00007fff934326ea -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
    6   CoreFoundation                      0x00007fff9338a5ce ___forwarding___ + 414
    7   CoreFoundation                      0x00007fff9338a3b8 _CF_forwarding_prep_0 + 232
    8   QSInterface                         0x0000000100247818 -[QSObjectView setObjectValue:] + 104
    9   QSInterface                         0x0000000100253c17 -[QSSearchObjectView selectObjectValue:] + 487
    10  QSInterface                         0x000000010022d9fd -[QSCollectingSearchObjectView selectObjectValue:] + 109

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 31, 2013

OK, I've fixed that bug, but now I've found another:

  • Select an action that selects nil in the 3rd pane by default (say the 'append to...' action or the search for... action if your search clipboard is empty)
  • Leave the dObject as it is
  • change the aObject to another object that uses the 3rd pane by short circuiting (␣)
  • Note how the iObj isn't updated

Can't fix it right now

pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented on 7295c43 Jan 31, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was redundant. I saw whilst in the debugger that setting the action (done a few lines above) already calls this method.

@skurfer
Copy link
Member

@skurfer skurfer commented Feb 1, 2013

The third pane for web searches isn't being "refreshed" as it should. As described on IRC, if you reinvoke the interface with a previous web search still showing, hitting runs the old search instead of going to text mode in the third pane. Also (probably the same bug), search text doesn't appear in the third pane. To reproduce:

  1. Bring up a web search
  2. Enter some text in the third pane
  3. Dismiss QS (or do the search - doesn't matter)
  4. Select some text in another application, then hit ⌘E
  5. Invoke QS

The text from the Find pasteboard should appear in the third pane, but it doesn't unless you change the dObject to something other than a web search, then back again.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Feb 1, 2013

hmm... I can't reproduce your 2nd problem, but if I reinvoke QS and press I see the 3rd pane isn't selected

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Feb 1, 2013

git bisect shows 03d921f is the culprit. Expected really as its an 'optimisation' - in inverted commas ;-)

skurfer added a commit that referenced this issue Feb 1, 2013
@skurfer skurfer merged commit 8a870a3 into master Feb 1, 2013
@pjrobertson pjrobertson deleted the smallFixes branch Feb 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants