recognize javascript: strings

[skurfer]

Just a quick fix up before the next release. Another hack like the mailto: thing, but it gets the job done.

Long term, we need to be less specific about various protocols. We should find a way to get this information out of launch services via Objective-C:

/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -dump | grep 'bindings:.*:'

Then, instead of checking specific prefixes, we can just split on : and see if the first component is on the list.

[pjrobertson]

as this seems to be the case, I think we should just go back to my 'generic' approach I previously proposed, no? Not specifically look for certain schemes, just be cleverer when sniffing URLs.

[skurfer]

This was meant to be quick, not good. :-) What was the generic approach again?

[pjrobertson]

Hmm... can't seem to find the original code. But it was generally just to
improve the sniffing method.
OK, quick fix it is. Feel free to merge

On 7 February 2013 18:33, Rob McBroom notifications@github.com wrote:

This was meant to be quick, not good. :-) What was the generic approach
again?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1376#issuecomment-13252023.