Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize javascript: strings #1376

Merged
merged 1 commit into from Feb 7, 2013
Merged

recognize javascript: strings #1376

merged 1 commit into from Feb 7, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Feb 7, 2013

Just a quick fix up before the next release. Another hack like the mailto: thing, but it gets the job done.

Long term, we need to be less specific about various protocols. We should find a way to get this information out of launch services via Objective-C:

/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/Support/lsregister -dump | grep 'bindings:.*:'

Then, instead of checking specific prefixes, we can just split on : and see if the first component is on the list.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 7, 2013

as this seems to be the case, I think we should just go back to my 'generic' approach I previously proposed, no? Not specifically look for certain schemes, just be cleverer when sniffing URLs.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 7, 2013

This was meant to be quick, not good. :-) What was the generic approach again?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 7, 2013

Hmm... can't seem to find the original code. But it was generally just to
improve the sniffing method.
OK, quick fix it is. Feel free to merge

On 7 February 2013 18:33, Rob McBroom notifications@github.com wrote:

This was meant to be quick, not good. :-) What was the generic approach
again?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1376#issuecomment-13252023.

skurfer added a commit that referenced this issue Feb 7, 2013
recognize javascript: strings
@skurfer skurfer merged commit cf45384 into quicksilver:master Feb 7, 2013
@skurfer skurfer deleted the javascript branch Feb 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants