Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoring pasteboard data for specific apps is handled by the plugin #1406

Merged
merged 7 commits into from May 14, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 22, 2013

An update to the plugin will appear soon with this check moved over to there :)

@pjrobertson
Copy link
Member Author

pjrobertson commented Feb 23, 2013

OK, some more commits that tidy up the pasteboard stuff.

Also, fixes #4

@pjrobertson
Copy link
Member Author

pjrobertson commented Feb 23, 2013

Oh yeah, and this is 10.7+ only. But we can drop 10.6 now right? :)

NSLocalizedString(@"PDF Image", @"Name of PDF image "), NSPDFPboardType,
NSLocalizedString(@"PNG Image", @"Name of a PNG image object"),
NSPasteboardTypePNG,
NSLocalizedString(@"RTF Text", @"NAme of a RTF text object"),
Copy link
Member

@skurfer skurfer Feb 23, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"NAme"

Copy link
Member Author

@pjrobertson pjrobertson Feb 23, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baaargh it's only a comment!

OK changed

pjrobertson added 5 commits Mar 20, 2013
Simply setting an icon in QSTypeDefinitions (Info.plist) will give an object an icon now
* Give all pasteboard objects IDs
* Put the object pasteboard type in the details
* Add a few new types (RTF)
* Fix up icons for images
* Add the source app name for unknown data objects
* Avoid just naming some objects @"Text"
@pjrobertson
Copy link
Member Author

pjrobertson commented Mar 20, 2013

OK, rebased against master to remove the conflict and 10.6 is dropped so this can be merged :)

Edit: tidied it all up. Magic!

@pjrobertson
Copy link
Member Author

pjrobertson commented May 10, 2013

OK, a bit slow on this one ;-)

I've fixed the problem. The "from XXX" (application) thing was only for objects that have an 'unknown type' (ones we can't decipher) so that's why we don't see it that often. It was happening here because I forgot to specify NSStringPboardType as a known type. :P

The plist Finder thing - I don't know, since I just get the 'source' app as the frontmost app. Perhaps you're switching to Finder really quickly before the clipboard plugin has had time to pickup the copied data, then is assuming it's from Finder. Anyway, you won't see it now.

Aside:

When we go UTI only, we won't need to bother with figuring out the type, we'll just use UTTypeCopyDescription

Returns the localized, user-readable type description string associated with a uniform type identifier.

:D easy peasy and you'll see things like 'plist format' or whatever for anything

skurfer added a commit that referenced this pull request May 14, 2013
ignoring pasteboard data for specific apps is handled by the plugin
@skurfer skurfer merged commit db2477c into quicksilver:master May 14, 2013
@pjrobertson pjrobertson deleted the pasteboard branch Dec 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants