Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few crashes/hangs from general QS use #1425

Merged
merged 3 commits into from Mar 20, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 16, 2013

Just small general things whilst using QS

  • if [objectDictionary allKeys] was nil then it'd cause a crash when trying to enumerate it
  • The identifier could get released in + (void)registerObject:(QSBasicObject *)object withIdentifier:(NSString *)anIdentifier if it was the same
  • A hang on loadAndReturnError - I think it's an Apple bug (reported it to them) but checking to make sure the bundle is actually and NSBundle can't do any harm

@pjrobertson
Copy link
Member Author

pjrobertson commented Mar 16, 2013

I've thrown in a few static analyzer fixes as well

@pjrobertson
Copy link
Member Author

pjrobertson commented Mar 18, 2013

Yeah I fixed that but forgot to push. If you haven't pulled I'll rebase

skurfer added a commit that referenced this pull request Mar 20, 2013
Fix a few crashes/hangs from general QS use
@skurfer skurfer merged commit 178577f into quicksilver:master Mar 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants