Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more internal commands for opening prefs. Fixes #1448 #1449

Merged
merged 2 commits into from Jun 17, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Mar 31, 2013

Nothing much to say

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 12, 2013

If I try "Show Guide", I get a crash. If you open the prefs first, then run it, it seems to work (with the Console messages below).

2013-06-12 14:55:55.970 Quicksilver[9870:4707] [QL] QLError(): -[QLSeamlessDocumentOpener _checkSeamlessOpeningState] should only be called in the main thread
2013-06-12 14:55:56.001 Quicksilver[9870:4707] *** WebKit discarded an uncaught exception in the webView:decidePolicyForNavigationAction:request:frame:decisionListener: delegate: <WebKitThreadingException> DOMDocument *kit(WebCore::Document *) was called from a secondary thread

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 13, 2013

Good spot. I've changed the code so it always runs on the main thread.
Strange that we never saw this cause a crash before - since we call the previously dodgy code all over the place.

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 13, 2013

Much better. Though in trying this, I noticed that we screwed up the icons for Plugins and Preferences on the right-hand side of the Guide somewhere along the way. (It's fine in 1.0.0, but messed up in master.) I'll try to look at it tomorrow if you don't get to it first.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 13, 2013

OK, I see that.

Also, in the setup assistant, if you flick to the 'plugins' pane the icon's messed up there as well. Off out for the day, so I won't get a chance to look at this right now.

On 13 Meh 2013, at 11:58, Rob McBroom notifications@github.com wrote:

Much better. Though in trying this, I noticed that we screwed up the icons for Plugins and Preferences on the right-hand side of the Guide somewhere along the way. (It's fine in 1.0.0, but messed up in master.) I'll try to look at it tomorrow if you don't get to it first.


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 13, 2013

It's because the standard and 2X versions are being combined into a TIFF. I can update the HTML, but since I'm not sure what controls this behavior, I worry that it could switch back in the future (like it did in the OpenMeta plug-in). Thoughts?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 15, 2013

oh yeah that problemo. Maybe you should change it, and we should make sure that "COMBINE_HIDPI_IMAGES" is set in the build settings:

http://stackoverflow.com/questions/5567897/combine-high-resolution-artwork-in-xcode-4

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 17, 2013

Maybe you should change it, and we should make sure that "COMBINE_HIDPI_IMAGES"

That's set now in Common.xcconfig. So I guess I'll change the HTML to reference TIFFs. My hesitation comes from the fact that the OpenMeta plug-in also has that setting enabled, and it was generating TIFFs at one point, but now preserves the original PNGs and I don't know why. I guess I'll just change it and we can keep an eye out.

skurfer added a commit that referenced this issue Jun 17, 2013
Add more internal commands for opening prefs. Fixes #1448
@skurfer skurfer merged commit 983d81f into quicksilver:master Jun 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants