Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide the iSelector if the action is being cleared. Fixes #1467 #1468

Merged
merged 2 commits into from Apr 23, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Apr 12, 2013

Does what it says on the tin.

This issue was present before, then I fixed it, and now it's back. This seems a bit 'hacky' but I don't think there's ever going to be a clean way of solving this

@skurfer
Copy link
Member

@skurfer skurfer commented Apr 12, 2013

Are there supposed to be two commits here? 😛

If I recall, you previously fixed this by telling it not to reload actions unless the type changed in the first pane. But that broke other things. Do I have that right? So this just changes the hiding without preventing actions from being recalculated, which I assume is safer.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Apr 12, 2013

Are there supposed to be two commits here?

Yep, you know what I'm like with sneaking commits into pull requests ;-)

Do I have that right? So this just changes the hiding without preventing actions from being recalculated, which I assume is safer.

Yep, that's what I originally did. Then that broke some things so I made it so that the 2nd pane action wasn't cleared at all (to avoid the flashing action icon bug if you remember), but that didn't fix the 3rd pane thing, so hopefully this does... with no side effects ;-)

The only thing so far is if you have all 3 panes visible then remove the action from pane 2 (using say ⌃U) it doesn't close the 3rd pane, but I don't see that as a bug

@skurfer
Copy link
Member

@skurfer skurfer commented Apr 23, 2013

it doesn't close the 3rd pane, but I don't see that as a bug

Me either.

skurfer added a commit that referenced this issue Apr 23, 2013
Don't hide the iSelector if the action is being cleared. Fixes #1467
@skurfer skurfer merged commit 240258e into quicksilver:master Apr 23, 2013
@pjrobertson pjrobertson deleted the i1467 branch Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants