Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unload icons for objects who's icon never changes #1488

Merged
merged 1 commit into from May 8, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 1, 2013

Being on a slow internet connection I realised web search icons were re-loading ever time the interface was opened/closed.

I noticed that these types of objects (and others after thinking about it) never need to reload their icons, so I've changed the code in a few places to set retainsIcon to YES.
Incase you're wondering, the flag is slighty misleading, it doesn't mean the icon is retained (retain count goes up by 1) but just that it's not released. When the object is dealloced the icon is of course still released.

@skurfer
Copy link
Member

@skurfer skurfer commented May 1, 2013

I imagine the aggressive unloading was done to keep the memory footprint down. That probably isn't as big a concern now. Testing this out.

skurfer added a commit that referenced this issue May 8, 2013
Don't unload icons for objects who's icon never changes
@skurfer skurfer merged commit 9df1ff2 into quicksilver:master May 8, 2013
@pjrobertson pjrobertson deleted the retainIcons branch Jun 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants