Improve ⌘V for non-latin keyboards #1529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
If the 'v' key doesn't exist on the current keyboard, fall back to using the key that is at the same location on the current keyboard (keycode 9)
Pretty simple really. If
NDKeyboardLayout
can't find the 'v' key, then just use a hard coded keycode which corresponds to the 'v' key on a British/US keyboardTo test:
Before this merge, change your keyboard layout to something like Korean, then attempt to use "Some text" ⇥ "Paste" (you may need to scroll for paste since you can't search for it using a Korean keyboard!)
Note that it won't work. Try again after merging this