Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ⌘V for non-latin keyboards #1529

Merged
merged 1 commit into from Jul 12, 2013
Merged

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 4, 2013

If the 'v' key doesn't exist on the current keyboard, fall back to using the key that is at the same location on the current keyboard (keycode 9)

Pretty simple really. If NDKeyboardLayout can't find the 'v' key, then just use a hard coded keycode which corresponds to the 'v' key on a British/US keyboard

To test:

Before this merge, change your keyboard layout to something like Korean, then attempt to use "Some text" ⇥ "Paste" (you may need to scroll for paste since you can't search for it using a Korean keyboard!)
Note that it won't work. Try again after merging this

If the 'v' key doesn't exist on the current keyboard, fall back to using the key that is at the same location on the current keyboard (keycode 9)
@skurfer
Copy link
Member

@skurfer skurfer commented Jul 10, 2013

Looks like a pretty small change. Can I just trust you? 😃

I'll at least make sure it doesn't break anything.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jul 10, 2013

Yep, it's only a fallback case as well.
I got the idea from Pierre of Type2Phone who does the same thing in his app, so it's tried and tested ;-)

skurfer added a commit that referenced this issue Jul 12, 2013
Improve ⌘V for non-latin keyboards
@skurfer skurfer merged commit e703f22 into quicksilver:master Jul 12, 2013
@pjrobertson pjrobertson deleted the cmdv branch Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants