Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate commands from the command history #1532

Merged
merged 1 commit into from Jul 12, 2013
Merged

Remove duplicate commands from the command history #1532

merged 1 commit into from Jul 12, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 9, 2013

This got on my nerves today.

If you run the same command say 5 times from QS, you'll notice in Prefs > Catalog > Quicksilver > Recent Commands has the same command 5 times.

I just needed to implement an isEqual: method for QSCommands (I guessed that testing the d/a/iObjects for equality was enough, but correct me if I'm wrong). I used pointer comparison as opposed to isEqual: for the objects, since isEqual doesn't work nicely with nil (typically what the `iObject is).

skurfer added a commit that referenced this issue Jul 12, 2013
Remove duplicate commands from the command history
@skurfer skurfer merged commit 50c25fd into master Jul 12, 2013
@skurfer skurfer deleted the cmdHistory branch Jul 12, 2013
@philostein
Copy link
Contributor

@philostein philostein commented Aug 12, 2013

Tried this out in 1.0.1:i1552 (4002) and saw some weird behaviour:

http://dl.dropbox.com/u/157506/Recent%20Command%20behaviour%20in%20Quicksilver.mov

Entering new text in pane 1 for a command changes all the text objects in all recent commands to the new text object. Any command's text, not just Large Type commands.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Aug 12, 2013

That's actually the weirdest and most wonderful bug I've ever fixed. It had nothing to do with the changes here (check v1.0 - it's the same), but I guess it only became evident because you were testing out this bug fix ;-)

How on earth Quicksilver has functioned with this bug for 10 years, I don't know.
Anyhow, it should be fixed in the next release :)

On 12 Awst 2013, at 18:57, Philo notifications@github.com wrote:

Tried this out in 1.0.1:i1552 (4002) and saw some weird behaviour:

http://dl.dropbox.com/u/157506/Recent%20Command%20behaviour%20in%20Quicksilver.mov

Entering new text in pane 1 for a command changes all the text objects in all recent commands to the new text object. Any command's text, not just Large Type commands.


Reply to this email directly or view it on GitHub.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Aug 12, 2013

P.S. your video led me to fix this, which fixed 3 existing QS bugs (and probably more) - good work Phil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants