Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused frameworks #1535

Merged
merged 11 commits into from Jul 24, 2013
Merged

Remove some unused frameworks #1535

merged 11 commits into from Jul 24, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jul 15, 2013

Alternate title: The Red Pull Request

This started with an error building under 10.9. It can't find the Messages.framework (although it seems to be there). Anyway, I saw that it wasn't used so I removed it. Then I started looking at all the other included frameworks and wondering what else we could take out. I think I've pared it down to what we actually need.

I also removed a few imports as I found them, and all the iSync stuff.

It seems like we should be able to remove the Carbon framework from everything other than the QSFoundation target, but when I try it, things don't go so well. 馃槂

This is not an attempt to clean up all unused stuff. I'm sure there are many, many more #import statements we could drop.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 15, 2013

Dammit you got there before me. I'm still in the process of dowloading Xcode 5 (yes, slow internet is annoying), but I did see that Messages was deprecated

If you're running 10.9 at any point, here's a couple of bugs I think I found (but it may just be that I'm running inside a VM):

  • Cube rotation on setup assistant. The original rotation was from the private CGS (CGSPrivate) stuff, so I'm not really fussed about fixing this one anyway.
  • The bump/nudge that happens in the results list doesn't seem to work (when 鈫 into a QSObj that has no children)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 24, 2013

Nice, good to see a load of cleanup. Nothing to say really except... I'm not sure if this will break some plugins that require various frameworks here and there (and don't import them in the project), but even if it does - that's the problem of the plugin to fix.

Merged.

pjrobertson added a commit that referenced this issue Jul 24, 2013
Remove some unused frameworks
@pjrobertson pjrobertson merged commit f9e0c91 into quicksilver:master Jul 24, 2013
@skurfer skurfer deleted the unused branch Jul 24, 2013
@skurfer
Copy link
Member Author

@skurfer skurfer commented Jul 24, 2013

I don't think we need to worry about that. After all, the targets that make up the app don't have access to the frameworks included in the other targets, so I doubt the plug-ins would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants