display file icons before attempting to load Quick Look previews #1554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As discussed in #1552, attempting to load Quick Look previews before giving up and showing the file's icon instead introduced a noticeable delay. I changed it to show the file's icon (if it exists) first. The obvious downsides are the extra work of loading two icons, and sending two notifications. But loading the file's icon is usually lightning quick. (Almost no one complained about it when it was done on the main thread.) And if there is no Quick Look preview, the second notification never happens.