Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make results view resizing superfluous #1565

merged 4 commits into from Aug 12, 2013

Make results view resizing superfluous #1565

merged 4 commits into from Aug 12, 2013


Copy link

@pjrobertson pjrobertson commented Aug 12, 2013

Why don't people like superfluity :'(


See here for a discussion on the matter

@@ -51,7 +51,9 @@ - (void)setOpaque:(BOOL)flag {
- (void)drawRow:(NSInteger)rowIndex clipRect:(NSRect)clipRect {
// drawingRow = rowIndex;

if (![[self window] isVisible]) {
Copy link

@skurfer skurfer Aug 12, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is working. I’m seeing a lot of places where the results list is just blank until I arrow around to force a redraw.

It only seems to happen with superfluous effects off. I assume because the now-optional code above in QSResultController.m is causing a redraw.

Copy link

@skurfer skurfer commented Aug 12, 2013

I'm glad I had you move that commit over here. I might not have noticed if it weren't for testing the superfluous pref at the same time. 😃

This reverts commit 75e4867.
Unfortunately this was a premature optimisation. Maybe one day we can avoid the excessive redrawing
skurfer added a commit that referenced this issue Aug 12, 2013
@skurfer skurfer merged commit b05d52e into release Aug 12, 2013
@skurfer skurfer deleted the resultsview branch Aug 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants