Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the focus ring around the search text field #1579

Merged
merged 1 commit into from Aug 27, 2013
Merged

remove the focus ring around the search text field #1579

merged 1 commit into from Aug 27, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Aug 22, 2013

This is only noticeable (and obnoxious) under 10.9. I can't see any difference under 10.8, which makes me wonder why someone went out of their way to define that method.

I checked for the commit that added it. If you guessed “Code cleanup”, you get this 🍰.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 23, 2013

Maybe it was something to do with the accessibility stuff... #898
But that wouldn't make sense because it's not merged.

Maybe the truth is that it was a 'bug' in OS X 10.0+ (the value wasn't being respected), and Apple have only just fixed the bug. Took em a while eh?

Feel free to merge, but do you think it'd be good to make a '10.9' branch to merge 10.9 fixes into, or is straight into master OK?

P.S. how do you fancy sending me that 🍰 ? I prefer chocolate, if I get a preference ;-)

@skurfer
Copy link
Member Author

@skurfer skurfer commented Aug 23, 2013

Maybe it was something to do with the accessibility stuff

No, I checked and it goes back to at least B54.

I don't see a need for a 10.9 branch, unless it's a change that breaks something in 10.8, but if that's the case, it's probably going to wait until we drop 10.8 support, which is quite a way off, right?

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 23, 2013

I don't see a need for a 10.9 branch

Yeah no real need, but it's often the convention. And it'd be nice for keeping track of what we've fixed for 10.9, and making it 'easy' for people to test a 10.9 compatible QS.

I'll see what you think from wherever this pull ends up - in master or 10.9 ;-)

skurfer added a commit that referenced this issue Aug 27, 2013
remove the focus ring around the search text field
@skurfer skurfer merged commit a6001c0 into master Aug 27, 2013
@skurfer skurfer deleted the focusRing branch Aug 27, 2013
@toph-allen
Copy link

@toph-allen toph-allen commented Sep 13, 2013

I just updated Quicksilver to the latest version and noticed this problem start. It's persisted across a reboot, too.
screen shot 2013-09-13 at 4 31 09 pm

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 13, 2013

Thanks for the info toph-allen.

This is fixed in the latest HEAD of Quicksilver, but not v1.1. If you want to get rid of it then try building directly from source. See http://qsapp.com/wiki/Building_Quicksilver
The next release of Quicksilver will contain the fix (which we will release well before Mavericks is out of DP)

@pjrobertson pjrobertson mentioned this pull request Sep 17, 2013
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants