Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep AppKit calls on the main thread #1584

Merged
merged 2 commits into from Sep 4, 2013
Merged

keep AppKit calls on the main thread #1584

merged 2 commits into from Sep 4, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Aug 29, 2013

I've attempted to address #1583 here. Let me know if I've misunderstood. (Or feel free to push additional commits. It's on the main repo.)

@tiennou
Copy link
Member

@tiennou tiennou commented Aug 29, 2013

Looks good. This could be restricted to the first line only but I don't think it matters... Thanks Rob !

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 29, 2013

Looks good. This could be restricted to the first line only but I don't think it matters... Thanks Rob !

I agree, I think it'd be tidier and more obvious as to why we're doing it. Doesn't really matter but may be neater? :)

On 30 Awst 2013, at 05:50, Etienne Samson notifications@github.com wrote:

Looks good. This could be restricted to the first line only but I don't think it matters... Thanks Rob !

@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 3, 2013

OK. I'll fix it.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 3, 2013

Fixed. If you'd rather a new cleaner branch, let me know.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 4, 2013

No worries, looks fine

pjrobertson added a commit that referenced this issue Sep 4, 2013
keep AppKit calls on the main thread
@pjrobertson pjrobertson merged commit 3fbc7cb into master Sep 4, 2013
@skurfer skurfer deleted the i1583 branch Sep 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants