Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning frenzy. #1585

Merged
merged 23 commits into from Sep 16, 2013
Merged

Warning frenzy. #1585

merged 23 commits into from Sep 16, 2013

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Aug 31, 2013

49 warnings, down to 11 (here at least). Makes the warning view much more useful ;-).

Things I left :

  • NSWorkspace_BLTRExtensions: 2 warnings about -launchedApplications being deprecated. I would recommend killing some methods in that file, using the shiny new -runningApplications (10.6+) that takes over the old NSDictionaries from NSWorkspace. Some of those aren't even used (I did a quick check on the old Plugins repo and got some matches, so plugins should be checked).
  • I left the 3 #warnings in QSPlugInManager. Yeah, I think those are mine, but I don't feel like tinkering with that class atm.
  • @pjrobertson, there's a special one for you in QSPluginUpdater.xib. I can't fathom what Xcode is trying to tell me here...
  • The 4 others are in the externals (and it makes me realize my count if of by some easy ones I fixed in VDKQueue). I'll do a pull req for those.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 31, 2013

Sounds good, just a quick comment about the VDKQueue: bdkjones/VDKQueue#7

It's only been sitting there 8 months :)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Aug 31, 2013

Oh and:
@pjrobertson, there's a special one for you in QSPluginUpdater.xib. I can't fathom what Xcode is trying to tell me here…
I couldn't figure this one out either… since it's mine I'll look closer :)

On 1 Medi 2013, at 07:08, Etienne Samson notifications@github.com wrote:

@pjrobertson, there's a special one for you in QSPluginUpdater.xib. I can't fathom what Xcode is trying to tell me here...

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 1, 2013

@tiennou I see no error for the QSPluginUpdater.xib right now? I only sometimes see it... strange
Maybe a derived data thing?

Also, it might be worth doing: Editor → Validate Settings...
There are a few small things to change (Xcode 4.5 on Mavericks has lots more useful ones as well)

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 1, 2013

We're talking about a warning, right ? I did a rm -R DerivedData in a well-known place, and my warn count is still 12.

I'll see about Validate Settings (in fact I thought I had taken care of that in 4ad85b9...).

I'm sharing a screenshot, because it is too much fun for me (straight after I killed DerivedData). Please carefully notice the warning count in the top view, and at the bottom of the screen. Consider arbitrary local discrepancy to be normal behavior ;).

capture decran 2013-09-01 a 13 28 40

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 3, 2013

Please carefully notice the warning count in the top view, and at the bottom of the screen. Consider arbitrary local discrepancy to be normal behavior ;).

I think it might be saying “I have 12 things you should know about. 11 of them are warnings.” My guess on the 12th is the “Validate project settings” message, but maybe I’m giving Xcode too much credit.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 3, 2013

Any idea what’s going on here (when I switch to this branch)?

% git status
# On branch tiennou-warning-frenzy
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#   modified:   Quicksilver/Code-External/VDKQueue (new commits)
#
no changes added to commit (use "git add" and/or "git commit -a")

% git submodule update
fatal: reference is not a tree: 4879a00b5436b043a3644c655a51cf0adce3e828
Unable to checkout '4879a00b5436b043a3644c655a51cf0adce3e828' in submodule path 'Quicksilver/Code-External/VDKQueue'

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 3, 2013

Yeah, a missing commit in the submodule (either that or it's trying to fetch from bdkjones/VDKQueue while a subsequent commit switched the source). Try git submodule sync first (to bring the submodule's origin remote in line with what's in .gitmodules).

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 3, 2013

Yeah, my existing directory had the original as its only remote. The sync got it pointing to our fork. Thanks.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 3, 2013

This branch has a number of conflicts with release. Most notably, in Quicksilver.xcodeproj/project.pbxproj. Maybe we should wait until release and master come together before we fix the warnings?

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 3, 2013

Depends. I wasn't expecting that to go to release anyways, and I can take care of merging in changes for the next release.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 3, 2013

If you want, I can go ahead and merge release into master, then you can rebase this on the result.

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 4, 2013

If that's a logical next step, yes. I don't know where you guys are in the release cycle ;-).

Conflicts:
	Quicksilver/Code-QuickStepCore/QSObject.m
	Quicksilver/Localized/ca-ES.lproj/About.strings
	Quicksilver/Localized/ca-ES.lproj/Localizable.strings
	Quicksilver/Localized/ca-ES.lproj/QSActionsPrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSAdvancedPrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSAppearancePrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSApplicationPrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSCatalog.strings
	Quicksilver/Localized/ca-ES.lproj/QSHelpersPrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSPlugInsPrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSSearchPrefPane.strings
	Quicksilver/Localized/ca-ES.lproj/QSTriggersPrefPane.strings
	Quicksilver/Localized/nb-NO.lproj/QSCatalog.strings
	Quicksilver/Localized/zh-Hans.lproj/Localizable.strings
	Quicksilver/Localized/zh-Hans.lproj/QSAppearancePrefPane.strings
	Quicksilver/Localized/zh-Hans.lproj/QSApplicationPrefPane.strings
	Quicksilver/Localized/zh-Hans.lproj/QSCatalog.strings
	Quicksilver/Localized/zh-Hans.lproj/QSSearchPrefPane.strings
	Quicksilver/Localized/zh-Hant.lproj/QSAdvancedPrefPane.strings
	Quicksilver/Quicksilver.xcodeproj/project.pbxproj
@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 10, 2013

Hop !

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 10, 2013

12 warnings everywhere, btw. And you were right, I did a "Validate settings", and the ghost warning disappeared.

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 10, 2013

Wait, I have leftovers ;-).

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 10, 2013

Ok good to go ;-) !

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 10, 2013

Re-wait, I managed to break the Quit window. Who would have knew that fixing warnings could introduce bugs ;-).

Though a never-quitable QS sounds like a great idea ;-).
@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 10, 2013

Ok, bug squished. That weird-looking init pattern wasn't weird for nothing...

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 12, 2013

Double-clicking a trigger in the prefs to edit it throws an exception. 😦

2013-09-12 15:04:40.441 Quicksilver[44535:303] -[QSApp beginSheetModalForWindow:completionHandler:]: unrecognized selector sent to instance 0x101605bc0
NSExceptionHandlerExceptionRaiser (in ExceptionHandling) + 174
objc_exception_throw (in libobjc.A.dylib) + 43
-[NSObject(NSObject) doesNotRecognizeSelector:] (in CoreFoundation) + 186
___forwarding___ (in CoreFoundation) + 414
_CF_forwarding_prep_0 (in CoreFoundation) + 232
-[QSTriggersPrefPane outlineView:shouldEditTableColumn:item:] (in Quicksilver) (QSTriggersPrefPane.m:515)
-[NSOutlineView _userCanEditTableColumn:row:] (in AppKit) + 153
-[NSTableView _userCanSelectAndEditTableColumn:row:] (in AppKit) + 97
-[NSTableView _shouldEditColumn:row:withEvent:] (in AppKit) + 121
-[NSTableView mouseDown:] (in AppKit) + 5858
-[NSOutlineView mouseDown:] (in AppKit) + 678
-[NSWindow sendEvent:] (in AppKit) + 6853
-[QSWindow sendEvent:] (in QSEffects) (QSWindow.m:185)
-[NSApplication sendEvent:] (in AppKit) + 5761
-[QSApp sendEvent:] (in Quicksilver) (QSApp.m:124)
-[NSApplication run] (in AppKit) + 636
NSApplicationMain (in AppKit) + 869
main (in Quicksilver) (main.m:21)
start (in Quicksilver) + 52
0x00000003 (in Quicksilver)
2013-09-12 15:04:40.511 Quicksilver[44535:303] -[QSApp beginSheetModalForWindow:completionHandler:]: unrecognized selector sent to instance 0x101605bc0
2013-09-12 15:04:40.514 Quicksilver[44535:303] (
    0   CoreFoundation                      0x00007fff916d2b06 __exceptionPreprocess + 198
    1   libobjc.A.dylib                     0x00007fff8a2623f0 objc_exception_throw + 43
    2   CoreFoundation                      0x00007fff91766f49 -[NSException raise] + 9
    3   ExceptionHandling                   0x000000010030d65b NSExceptionHandlerExceptionRaiser + 210
    4   libobjc.A.dylib                     0x00007fff8a2623f0 objc_exception_throw + 43
    5   CoreFoundation                      0x00007fff9176940a -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
    6   CoreFoundation                      0x00007fff916c102e ___forwarding___ + 414
    7   CoreFoundation                      0x00007fff916c0e18 _CF_forwarding_prep_0 + 232
    8   Quicksilver                         0x0000000100025e4f -[QSTriggersPrefPane outlineView:shouldEditTableColumn:item:] + 1375
    9   AppKit                              0x00007fff8a907fd8 -[NSOutlineView _userCanEditTableColumn:row:] + 153
    10  AppKit                              0x00007fff8a9abdad -[NSTableView _userCanSelectAndEditTableColumn:row:] + 97
    11  AppKit                              0x00007fff8a9b3ec8 -[NSTableView _shouldEditColumn:row:withEvent:] + 121
    12  AppKit                              0x00007fff8a9b6861 -[NSTableView mouseDown:] + 5858
    13  AppKit                              0x00007fff8a905759 -[NSOutlineView mouseDown:] + 678
    14  AppKit                              0x00007fff8a5a450e -[NSWindow sendEvent:] + 6853
    15  QSEffects                           0x00000001001502e2 -[QSWindow sendEvent:] + 962
    16  AppKit                              0x00007fff8a5a0644 -[NSApplication sendEvent:] + 5761
    17  Quicksilver                         0x0000000100002fdb -[QSApp sendEvent:] + 2683
    18  AppKit                              0x00007fff8a4b621a -[NSApplication run] + 636
    19  AppKit                              0x00007fff8a45abd6 NSApplicationMain + 869
    20  Quicksilver                         0x000000010002b316 main + 198
    21  Quicksilver                         0x0000000100002004 start + 52
)

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 12, 2013

Oops, right.

I broke it in f9e2dbf, but it's Xcode's fault ;-). Was I sending a message to an NSSavePanel, no ? THEN WHY THE HELL DID YOU PROPOSE THIS SO NICE-LOOKING-DOES-WHAT-I-WANT METHOD CALL IN THE COMPLETION LIST !!

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 12, 2013

(NSApp is extern'ed to id, augh...)

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 12, 2013

🎴

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 16, 2013

Going ahead with this. There might be some conflicts in the localized files. I guess we just prefer the version in master? Or take either version and update with transifex?

skurfer added a commit that referenced this issue Sep 16, 2013
@skurfer skurfer merged commit e90d88c into quicksilver:master Sep 16, 2013
@tiennou tiennou deleted the warning-frenzy branch Sep 16, 2013
@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 16, 2013

Yay ! Normally I redid the loc files changed in master in ccbbd7f so it wouldn't conflict.

And while I'm at it, @pjrobertson @skurfer is there anything you want me to "lose" time fixing ;-) ? I'm currently without a goal, and except rewriting big parts of QS code again and again, I feel a little goal-less. Some things I've noted :

  • the tasks crash which I opened a PR for.
  • finally making triggers complete (like the missing drag 'n drop in the pref pane + the ability to have more than one command per trigger). PR waiting on that one because I've just managed to break triggers ;-).
  • a crash I've got while executing -[QSObject cache] (an over-released object in an autorelease pool crash, under ARC, gnn...).
  • the QSCollection thing.
  • Trying to cleanup more of QSObject and it's mess of categories. The idea in #777 looks nice enough to me ;-).

Now I feel like I'm doing my own private contest ;-).

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 16, 2013

And while I'm at it, @pjrobertson @skurfer is there anything you want me to "lose" time fixing ;-) ?

I have some ideas, but they aren't simple fixes. Sounds like you have plenty to look at anyway. 😃

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 16, 2013

Nothing much in particular. From your list maybe QSCollections? But cleanup should come before that ;-)

Actually, we have tons of pulls open, so perhaps you could help me and Rob out looking over them and merging?

Goal number 1: merge all pull requests… hehe!

On 17 Medi 2013, at 02:35, Rob McBroom notifications@github.com wrote:

And while I'm at it, @pjrobertson @skurfer is there anything you want me to "lose" time fixing ;-) ?

I have some ideas, but they aren't simple fixes. Sounds like you have plenty to look at anyway.


Reply to this email directly or view it on GitHub.

@tiennou
Copy link
Member Author

@tiennou tiennou commented Sep 16, 2013

Ok, I hereby declare Pull-Request-Merge-Fest open ! But tomorrow ;-).

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 16, 2013

Uh oh, we're gonna have a lot to read ;-)

23 pull requests… (only 16 of which aren't yours.) I guess our part of the bargain is to read over yours and merge them.

Bonne nuit

On 17 Medi 2013, at 08:46, Etienne Samson notifications@github.com wrote:

Ok, I hereby declare Pull-Request-Merge-Fest open ! But tomorrow ;-).


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 17, 2013

Yes, please! Nothing new until we cut them down. 😃 In addition to checking others, we should check our own to see if there are outstanding issues we never got to.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 17, 2013

In addition to checking others, we should check our own to see if there are outstanding issues we never got to.

Probably some not-so-subtle hint there right? ;-)
I'll get on it as well, good idea :)

On 17 Medi 2013, at 11:19, Rob McBroom notifications@github.com wrote:

In addition to checking others, we should check our own to see if there are outstanding issues we never got to.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 17, 2013

I said “we”.

…but yeah, that was nothing but a hint. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants