Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the right selector for relaunchApplication (forgot the colon). Fixes #1604 #1605

Merged
merged 1 commit into from Sep 17, 2013

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 17, 2013

Well duh, it was just a typo - missed the colon.

Caught you @craigotis ;-)
8cb92f9#L3R178

Is there a reason why you used performSelector as opposed to calling the method directly?

@craigotis
Copy link
Contributor

@craigotis craigotis commented Sep 17, 2013

Ack, yes @pjrobertson, the typo was my fault. I didn't call it directly because neither NSWorkspace, nor any custom category, exposes that method - so it seems to be a private method.

@tiennou
Copy link
Member

@tiennou tiennou commented Sep 17, 2013

Oooh, private API ;-).

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 17, 2013

And people ask why we don't want to be in the App Store. Pffft.

skurfer added a commit that referenced this issue Sep 17, 2013
use the right selector for relaunchApplication (forgot the colon). Fixes #1604
@skurfer skurfer merged commit 75e2b30 into master Sep 17, 2013
@skurfer skurfer deleted the relaunchFix branch Sep 17, 2013
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 17, 2013

Whoops, only just seen your reply Craig, sorry... But if you look at the BLTR_Extensions for NSWorkspace you'll see that's where the methods defined.

Aha to you private API and non-App Store sayers ;)

On 17 Medi 2013, at 21:18, Rob McBroom notifications@github.com wrote:

And people ask why we don't want to be in the App Store. Pffft.


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 17, 2013

But if you look at the BLTR_Extensions for NSWorkspace you'll see that's where the methods defined.

Gah. I just looked in there the other day. Should have caught that.

@craigotis
Copy link
Contributor

@craigotis craigotis commented Sep 17, 2013

@pjrobertson @skurfer Ah - I see the confusion. There is a relaunchApplication: method implemented in the BLTR_Extensions category for NSWorkspace, but it seems it was never added to the header (and I didn't notice it originally in the .m file), so it didn't appear to be available.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 17, 2013

Good point, it probably needs adding, then we can just call the method straight off. I'll make the change and push straight to master if nobody has any complaints

( btw Rob: ⌘⇧F was my friend. No clever trickery on my part :P )

On 17 Medi 2013, at 22:24, Craig Otis notifications@github.com wrote:

@pjrobertson Ah - I see the confusion. There is a relaunchApplication: method implemented in the BLTR_Extensions category, but it was never added to the header (and I didn't see it in the .m file), so it didn't appear to be available.


Reply to this email directly or view it on GitHub.

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 17, 2013

I'll make the change and push straight to master

proceed-lolcat

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Sep 18, 2013

Uh oh, lol cats now...what is happening?! :o

Hehe, OK - pushed

@skurfer
Copy link
Member

@skurfer skurfer commented Sep 18, 2013

Uh oh, lol cats now...what is happening?!

Ha! I know. It’s terrible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants