Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch nil strings in text proxies #1624

Merged
merged 1 commit into from Sep 30, 2013
Merged

catch nil strings in text proxies #1624

merged 1 commit into from Sep 30, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Sep 28, 2013

I ran across a small bug this morning introduced by #1548.

To reproduce:

  1. Search for something with children (an artist from iTunes in my case).
  2. Right-arrow to show the children, then select one without typing any letters.
  3. Go to the second pane and call up “Assign Abbreviation…”.

Since there is no search text, there's an exception and the interface sort of loses its mind.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 30, 2013

I saw this bug, meant to create an issue, forgot about it. Then I saw your pull request, meant to comment on it, forgot about it.
Now I've just seen the bug, remembered your first pull (where I was going to comment about using a more graceful textProxyObjectWithDefaultValue) then saw this.

Merged

P.S. I hope you liked my life story ;-)

pjrobertson added a commit that referenced this issue Sep 30, 2013
catch `nil` strings in text proxies
@pjrobertson pjrobertson merged commit 455746c into master Sep 30, 2013
@pjrobertson pjrobertson deleted the abbreviation branch Sep 30, 2013
@skurfer
Copy link
Member Author

@skurfer skurfer commented Sep 30, 2013

P.S. I hope you liked my life story ;-)

The way you paint it… It’s like I’m there! :-)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Sep 30, 2013

I should write a book about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants