Trigger bugs #1650
Merged
Trigger bugs #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currentTrigger in this context always refers to the first one on the list so it always returns the same manager. selectedTrigger refers to the correct object.
…Field The old test would prevent you from being able to edit the trigger name.
|
Hmm... I wrote a long message on this, but it seems to have disappeared. I'm pretty sure it supersedes #1227 which we can now close (@tiennou?) The only thing I remember being I wanted to mention is that the Triggers aren't saved by simply editing the value for the trigger name. e.g. if you edit the name then instantly close the window, the triggers are never saved (see the console running QS Debug). This is a problem that's plagued the trigger sidebar for a long time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A couple of one-liners to restore my sanity.
This has bothered me for a looooong time: Open the settings for a trigger and try to edit the name/description at the top.😡
I was running into something similar with the delay setting in Event Triggers and finally tracked it down.
First, when setting up the view, it would always get the first trigger in your prefs instead of the trigger you were viewing. So the settings view for every trigger was treated like a settings view for hotkey triggers (in my case). The first commit fixes this for all non-hotkey triggers.
But you still couldn't edit the name for a hotkey trigger because, for some reason, other text fields in that view were being treated as hotkey capturing thingies™. The second commit enables that behavior only for instances of
QSHotKeyField. I can neither find, nor imagine what that might break.