Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger bugs #1650

Merged
merged 2 commits into from Nov 1, 2013
Merged

Trigger bugs #1650

merged 2 commits into from Nov 1, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Oct 15, 2013

A couple of one-liners to restore my sanity.

This has bothered me for a looooong time: Open the settings for a trigger and try to edit the name/description at the top. 😡

I was running into something similar with the delay setting in Event Triggers and finally tracked it down.

First, when setting up the view, it would always get the first trigger in your prefs instead of the trigger you were viewing. So the settings view for every trigger was treated like a settings view for hotkey triggers (in my case). The first commit fixes this for all non-hotkey triggers.

But you still couldn't edit the name for a hotkey trigger because, for some reason, other text fields in that view were being treated as hotkey capturing thingies™. The second commit enables that behavior only for instances of QSHotKeyField. I can neither find, nor imagine what that might break.

skurfer added 2 commits Oct 15, 2013
currentTrigger in this context always refers to the first one on the list so it always returns the same manager. selectedTrigger refers to the correct object.
…Field

The old test would prevent you from being able to edit the trigger name.
pjrobertson added a commit that referenced this issue Nov 1, 2013
@pjrobertson pjrobertson merged commit 4955630 into master Nov 1, 2013
@pjrobertson pjrobertson deleted the triggerBugs branch Nov 1, 2013
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 1, 2013

Hmm... I wrote a long message on this, but it seems to have disappeared. I'm pretty sure it supersedes #1227 which we can now close (@tiennou?)

The only thing I remember being I wanted to mention is that the Triggers aren't saved by simply editing the value for the trigger name. e.g. if you edit the name then instantly close the window, the triggers are never saved (see the console running QS Debug). This is a problem that's plagued the trigger sidebar for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants