Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #1665

Merged
merged 3 commits into from Nov 4, 2013
Merged

Small fixes #1665

merged 3 commits into from Nov 4, 2013

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Nov 1, 2013

Why should @pjrobertson be the only one putting out random collections of small fixes?

So, here are some things I ran across while working on various problems.

I’m could be wrong about c24e2be. It just seemed weird to me the way it was.

skurfer added 3 commits Nov 1, 2013
Most of the setup messages are being sent to `self`, not `result`.
It's called again two lines later.
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 4, 2013

If you pause the debugger in the code in c24e2be you'll notice that self and result point to exactly the same thing.
I don't get it, but what you're doing looks better :)

pjrobertson added a commit that referenced this issue Nov 4, 2013
@pjrobertson pjrobertson merged commit fda374c into master Nov 4, 2013
@pjrobertson pjrobertson deleted the smallFixes branch Nov 4, 2013
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 4, 2013

P.S. at least your random collections of small fixes are actually small. Mine always end up being massive pains-in-the-arse ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants