Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '~' on non-US keyboards. #1696

Merged
merged 1 commit into from Dec 10, 2013
Merged

Fix '~' on non-US keyboards. #1696

merged 1 commit into from Dec 10, 2013

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Dec 1, 2013

Some methods from protocol NSTextInputClient weren't implemented, which would cause an exception to be raised on '~'. This adds the necessary "boilerplate" to restore that functionality.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Dec 2, 2013

@tiennou - merge build failed :(
...but looking through the console output I can't really see why. Perhaps there's a build setting problem (ping @HenningJ )

Let me just say OK to test - we'll see if it works now

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented on e7198ad Dec 2, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I made the setMarkedText:selectedRange: in some other pull somewhere, but I did pretty much the same thing as you. Looks good (although I haven't tested the actual code)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Dec 2, 2013

as mentioned of at #1695: sometimes something was wrong with running the tests from jenkins. I've disabled that until I figure out how to do that properly. Everything should be fine now. Ok to test

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Dec 3, 2013

ok to test

skurfer added a commit that referenced this issue Dec 10, 2013
@skurfer skurfer merged commit 12f2239 into master Dec 10, 2013
1 check passed
@skurfer skurfer deleted the t/fix-accented-chars branch Dec 10, 2013
skurfer added a commit that referenced this issue Dec 10, 2013
skurfer added a commit that referenced this issue Dec 11, 2013
skurfer added a commit that referenced this issue Dec 11, 2013
skurfer added a commit that referenced this issue Dec 18, 2013
skurfer added a commit that referenced this issue Dec 19, 2013
skurfer added a commit that referenced this issue Jan 2, 2014
skurfer added a commit that referenced this issue Jan 14, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 17, 2014
skurfer added a commit that referenced this issue Jan 21, 2014
skurfer added a commit that referenced this issue Jan 25, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 2, 2014
skurfer added a commit that referenced this issue Feb 5, 2014
skurfer added a commit that referenced this issue Feb 11, 2014
skurfer added a commit that referenced this issue Mar 19, 2014
skurfer added a commit that referenced this issue Apr 14, 2014
skurfer added a commit that referenced this issue May 13, 2014
skurfer added a commit that referenced this issue May 30, 2014
skurfer added a commit that referenced this issue Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants